Project

General

Profile

Actions

Bug #97853

closed

Undefined array key access in DataMapFactory

Added by Francois Suter over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Extbase
Target version:
Start date:
2022-07-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.0
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

In a couple of places class \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapFactory accesses the TCA without checking if a definition really exists for the given table name. This causes warnings with PHP 8+.

Actions #1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75025

Actions #2

Updated by Francois Suter over 2 years ago

The scenario where I ended up having to fix the issues in the patch is the following:
  • I have extension "sf_register"
  • I am extending the fe_users table using extension "extender"
  • I have a special field type, which requires invoking a custom TypeConverter
  • when this happens, DataMapFactory is called up with the name of the extended class, which it tries to match to an Extbase-like table name ("tx_foo_domain_model_bar") which does not exist
  • simply avoiding errors in the places fixed in the patch, allows the process to flow freely
Actions #3

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75025

Actions #4

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74950

Actions #5

Updated by Anonymous over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF