Project

General

Profile

Actions
Copy link

Bug #97961

closed

Transform `tableoptions` early to valid `doctrine/dbal` option

Added by Stefan Bürk over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2022-07-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With #80398 support to set `tableoptions` to proper charset and
collate has been added. This setting has been passed through the
`doctrine/dbal` connection params and manually set to the schema
config for database compare, if it has been set.

The choosen key `tableoptions` however is not the valid key for
`doctrine/dbal` connection params. `doctrine/dbal` ships proper
phpstan/psalm type defitions for the param array nowerdays.

Raising dependency version for doctrine/dbal and phpstan leads to
error reporting of this hackish missuse to transport the settings
from Typo3 database configuration to the schema migrator config.

Related issues 4 (0 open — 4 closed)

Related to TYPO3 Core - Feature #80398: Make default charset and collation for new tables configurableClosed2017-03-22

Actions
Related to TYPO3 Core - Task #97956: Bump the Doctrine dependenciesClosed2022-07-16

Actions
Related to TYPO3 Core - Task #105289: Mitigate deprecated Doctrine DBAL connection optionsClosedStefan Bürk2024-10-12

Actions
Related to TYPO3 Core - Task #105297: Deprecate `tableoptions` and `collate` connection configurationClosedStefan Bürk2024-10-13

Actions
Actions
Copy link
 #1

Updated by Stefan Bürk over 2 years ago

  • Related to Feature #80398: Make default charset and collation for new tables configurable added
Actions
Copy link
 #2

Updated by Stefan Bürk over 2 years ago

  • Related to Task #97956: Bump the Doctrine dependencies added
Actions
Copy link
 #3

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75211

Actions
Copy link
 #4

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75211

Actions
Copy link
 #5

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75211

Actions
Copy link
 #6

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75213

Actions
Copy link
 #7

Updated by Stefan Bürk over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #8

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #9

Updated by Stefan Bürk about 1 month ago

  • Related to Task #105289: Mitigate deprecated Doctrine DBAL connection options added
Actions
Copy link
 #10

Updated by Stefan Bürk about 1 month ago

  • Related to Task #105297: Deprecate `tableoptions` and `collate` connection configuration added
Actions
Copy link

Also available in: Atom PDF