Project

General

Profile

Actions
Copy link

Bug #98333

open

Inconsistent behavior while saving content elements with *required* fields

Added by Julian Mair almost 2 years ago. Updated 5 days ago.

Status:
Needs Feedback
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2022-09-12
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Summary
If you edit an element with required fields and click the normal save button (in the top headerbar), you can get an alert which says that some are not correctly filled. But with the save and view button, you can bypass the whole check and leave the element broken in place. The Fluid code has not always a check if such a field is not given – we would rely on the backend to prevent this.

I tested it with the "Categorized content" element, the Selected categories field is required. But I think every element with required fields has problems.

Expected behavior
The "Save and view" button gives the same alert message as the normal one – preventing to save the element.

Actual behavior
The "Save and view" button bypasses the expected behavior and saves/shows the element in a new tab.

Tested Typo3 versions
  • v11.5.15
  • v10.4.31
  • v9.5.31
  • (maybe also v12 or older versions than v9 – I didn't test them)

Files

Download all files
Screenshot from 2023-08-04 09-16-13--copy.png (130 KB) Screenshot from 2023-08-04 09-16-13--copy.png Julian Mair, 2023-08-04 07:23
Screenshot from 2023-08-04 09-16-33--copy.png (162 KB) Screenshot from 2023-08-04 09-16-33--copy.png Julian Mair, 2023-08-04 07:23
Actions
Copy link
 #1

Updated by Andreas Kienast 11 months ago

  • Status changed from New to Needs Feedback

Hey, thank you for your report. TYPO3 doesn't have a "Save & View" button anymore since v10, IIRC. Do you by chance have a 3rd party extension installed that re-implements this feature?

Actions
Copy link Download all files
 #2

Updated by Julian Mair 11 months ago

Hey Andreas, no there is no 3rd party extension - this comes from the core. I append 2 screenshots to explain it a bit better. If you have more questions, feel free to ask. Thanks.

Actions
Copy link
 #3

Updated by Andreas Kienast 11 months ago

Alright, thank you for your clarification. I was under the assumption you meant the old "Save & View" button.

Actions
Copy link
 #4

Updated by Riccardo De Contardi 6 days ago

I tried to perform a test on TYPO3 13 but I am unsure if my test is correct:

1) I added on a page a “Form engine - required“ record
2) without saving it I clicked on “view” button

A modal “You currently have unsaved changes. You can either discard these changes or save and view them.” opens

I clicked on the button “Save changes and view”

Result

- The browser opens a new tab, but it is stuck on a about:blank page
- TYPO3 backend shows an alert modal: “The fields marked with an exclamation mark are not yet correctly filled in. Please complete them properly.”

Is this test sufficient or a different test is necessary?

Actions
Copy link
 #5

Updated by Julian Mair 5 days ago · Edited

Hey Riccardo, this test is perfect. I followed the same steps in TYPO3 v12 (and older), and it behaved as described in the issue. Unfortunately, I don't have a v13 available to test, but I'm glad this is now fixed. Do you know the corresponding issue/review link for this fix by any chance?

Thanks!

Actions
Copy link

Also available in: Atom PDF