Project

General

Profile

Actions

Task #99098

closed

Replace instance cache in FormProtectionFactory with runtime cache

Added by Stefan Bürk over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2022-11-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

FormProtectionFactory is in transition to be fully
injectable, thus removing the old static instance
approach.

One showstopper to move on was the static property
cache for created instances, along with the need
to keep some protected methods static - with usage
in static and instanciated flavour.

Replaceing the static property instance cache with
the core runtime cache that knot would be solveable.

With that replacement, it would also be easier in
tests, and enforced clearing can be done by flushing
the runtime cache. Additionally, static `get()` and
`purgeInstances()` could be removed, and all of the
other static methods transformed into non-static variants.


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Task #98696: Make FormProtectionFactory injectable - part 2ClosedBenni Mack2022-10-21

Actions
Related to TYPO3 Core - Task #98627: Make FormProtectionFactory injectableClosedBenni Mack2022-10-16

Actions
Related to TYPO3 Core - Task #101013: Remove deprecated methods in FormProtectionFactory ClosedThomas Hohn2023-06-13

Actions
Actions #1

Updated by Stefan Bürk over 1 year ago

  • Related to Task #98696: Make FormProtectionFactory injectable - part 2 added
  • Related to Task #98627: Make FormProtectionFactory injectable added
Actions #2

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76634

Actions #3

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76634

Actions #4

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76634

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76634

Actions #6

Updated by Stefan Bürk over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions #8

Updated by Christian Kuhn 11 months ago

  • Related to Task #101013: Remove deprecated methods in FormProtectionFactory added
Actions

Also available in: Atom PDF