Project

General

Profile

Actions

Bug #99243

closed

Wrong behaviour when using property and value together

Added by Josua Vogel almost 2 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Category:
Fluid
Target version:
-
Start date:
2022-12-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

According to the docs, name and value should be ignored, if property is set. I`m using the view helper like this:

<f:form.textfield
                    id="{id}" 
                    name="customName" 
                    property="{property}" 
                    value="customValue" 
                    placeholder="{placeholder}" 
                    class="input__field form-control{f:if(condition: '{class}', then: ' {class}')}" 
                    errorClass="{errorClass}" 
                    additionalAttributes="{additionalAttributes}" 
                    data="{data}" 
                    aria="{describedby: 'error-label-{id}'}" 
                />

This is the result:

<input required="required" aria-describedby="error-label-email" class="input__field form-control" id="email" type="text" name="tx_myextension[customerData][email]" value="customValue">

The name attribute is ignored, but not the value attribute.
I´m not sure, what is wrong. Maybe the code, maybe the docs.

Inside the view helper, I found this part:

* The value is determined as follows:
     * * If property mapping errors occurred and the form is re-displayed, the *last submitted* value is returned
     * * Else the bound property is returned (only in objectAccessor-mode)
     * * As fallback the "value" argument of this ViewHelper is used

if ($this->respectSubmittedDataValue) {
            $value = $this->getValueFromSubmittedFormData($value);
        } elseif ($this->hasArgument('value')) {
            $value = $this->arguments['value'];
        } elseif ($this->isObjectAccessorMode()) {
            $value = $this->getPropertyValue();
        }

I can fix this, if someone tells me, which would be the correct behaviour.


Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Bug #93527: Assigned form-object does not overwrite default-valuesClosed2021-02-17

Actions
Actions #1

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77681

Actions #2

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77681

Actions #3

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77681

Actions #4

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77681

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77681

Actions #6

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77681

Actions #7

Updated by Simon Praetorius about 1 year ago

  • Has duplicate Bug #93527: Assigned form-object does not overwrite default-values added
Actions #8

Updated by Benni Mack 4 months ago

  • Status changed from Under Review to New
Actions #9

Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85413

Actions #10

Updated by Garvin Hicking 4 months ago · Edited

Previous patch has been abandoned with a discussion about "intentional behavior" of the "value" attribute.
One possible example why both attributes together may make sense is a form to edit a user. For the password field you would want to define property="password", but also value="" to not expose the current password hash to the form.

Thus, the new patch adjusts the inline code comment to reflect that intention.

Actions #11

Updated by Garvin Hicking 4 months ago

  • Assignee set to Garvin Hicking
Actions #12

Updated by Garvin Hicking 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF