Project

General

Profile

Actions
Copy link

Bug #99767

open

Allowed file types are not displayed with type="input", renderType="inputLink" and new type="link" (in v12)

Added by Sybille Peters almost 2 years ago. Updated almost 2 years ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2023-01-31
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
backend usability
Complexity:
Is Regression:
Sprint Focus:

Description

This used to be the case with type="inline". Here, the allowed file types were displayed in the form and in the link browser.

Reproduce

There is an example extension available to reproduce, was tested with v12 latest main:

https://github.com/sypets/sypets_example_inputlink

1. in Backend insert a plugin using the "Content element wizard" in tab plugins "InputLink plugin"
2. check out the fields in "plugin" tab and compare the behaviour of various types
3. Look at flexform file

Screenshot

in type="file" the allowed file extensions are displayed (as previously in "inline") in type="link" and renderType="linkType" not.

Versions

  • used latest v11 (11.5.22)
  • this can also be reproduced with v12, with type="link"

Example

<settings.link>
  <TCEforms>
    <label>Link</label>
    <config>
      <type>input</type>
      <renderType>inputLink</renderType>
      <fieldControl>
        <linkPopup>
          <options>
            <allowedExtensions>bib</allowedExtensions>
            <blindLinkFields>class,param,target,title</blindLinkFields>
            <blindLinkOptions>page,mail,telephone,folder,tx_calendarize_domain_model_event,news</blindLinkOptions>
            <title>Select specific file (*.bib)</title>
          </options>
        </linkPopup>
      </fieldControl>
    </config>
  </TCEforms>
</settings.link>

Documentation

Files

Screenshot_show_allowed_file_extensions.png (27.6 KB) Screenshot_show_allowed_file_extensions.png Sybille Peters, 2023-01-31 13:25

Related issues 1 (1 open — 0 closed)

Related to TYPO3 Core - Bug #99766: Make it possible to deactivate "Add new media asset" in linkbrowser for type=input und renderType=inputLink and new type="link" (v12)New2023-01-31

Actions
Actions
Copy link
 #1

Updated by Sybille Peters almost 2 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Sybille Peters almost 2 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Sybille Peters almost 2 years ago

  • Subject changed from Allowed file types are not displayed with type="input", renderType="inputLink" to Allowed file types are not displayed with type="input", renderType="inputLink" and new type="link" (in v12)
Actions
Copy link
 #5

Updated by Oliver Bartsch almost 2 years ago

  • Status changed from New to Needs Feedback

Hi Sybille, which information, based on which config do you miss compared to previous versions?

I can't remember, renderType="inputLink" displayed any "allowed file types" in any previous TYPO3 version. Could it be, that this is actually a feature request?

Best, Oli

Actions
Copy link
 #6

Updated by Sybille Peters almost 2 years ago

@Oliver thanks for the feedback.

bug or feature request is always a matter of perspective ;-)
I would like to leave that up to you as core developer.

I can't remember, renderType="inputLink" displayed any "allowed file types" in any previous TYPO3 version. Could it be, that this is actually a feature request?

Correct, that is not possible in inputLink. It affects inputLink and link types. But I changed my Flexform from type "inline" where the allowed file types were displayed.

For me, if this is classified as "feature", there won't be a chance to backport it to v11 (but that might also not be possible for patch of type bug).

I would expect the allowed file types to be displayed just like they are for type file / inline (in case files are selectable here).

I have this specific use case where I explicitly need a type="inputLink" or type="link" (type='file' does not suffice) and have been struggling to find a way to make it behave as intended (as described above). I was surprised that the allowed file types were not displayed. It would be nice to have that for better usability in the BE.

Actions
Copy link
 #7

Updated by Sybille Peters almost 2 years ago

  • Status changed from Needs Feedback to New
Actions
Copy link
 #8

Updated by Sybille Peters almost 2 years ago

  • Related to Bug #99766: Make it possible to deactivate "Add new media asset" in linkbrowser for type=input und renderType=inputLink and new type="link" (v12) added
Actions
Copy link
 #9

Updated by Sybille Peters almost 2 years ago

I have already looked in the code, but it looks a bit difficult. Specifically, how to reuse certain parts and behaviour.

For type=file, FilesControlContainer is used, which uses Fluid:

<f:if condition="{allowedFileTypes}">
<div class="help-block">
    <f:translate key="LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:cm.allowedFileExtensions"/><br>
    <f:for each="{allowedFileTypes}" as="allowedFileType">
        <span class="badge badge-success">{allowedFileType}</span>
    </f:for>
</div>
</f:if>
Actions
Copy link

Also available in: Atom PDF