Task #99860
closed
Improve comments and readability in PageArgumentValidator
100%
Description
Make clear that the early-bail out for empty pageArguments is
done to prevent setting `disableCaches` to `true`.
Also makes that that the $pageNotFoundOnCacheHashError
condition is really tied to pageArguments being non-empty.
Prevents us from refactoring that code and missing this bit.
Updated by Benjamin Franzke almost 2 years ago
- Related to Bug #99859: Avoid disabling page caches when having cHash validation enforced added
Updated by Gerrit Code Review almost 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77735
Updated by Gerrit Code Review almost 2 years ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77752
Updated by Gerrit Code Review almost 2 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77753
Updated by Benjamin Franzke almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset db06e6869486fd770fb41c5e0405fcc2add636c6.
Updated by