Project

General

Profile

Actions

Task #99860

closed

Improve comments and readability in PageArgumentValidator

Added by Benjamin Franzke almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
Start date:
2023-02-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Make clear that the early-bail out for empty pageArguments is
done to prevent setting `disableCaches` to `true`.

Also makes that that the $pageNotFoundOnCacheHashError
condition is really tied to pageArguments being non-empty.
Prevents us from refactoring that code and missing this bit.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #99859: Avoid disabling page caches when having cHash validation enforcedClosed2023-02-06

Actions
Actions

Also available in: Atom PDF