Project

General

Profile

Actions

Bug #99877

closed

codemirror editor in backend modals needs proper dimensions

Added by Josef Glatz almost 2 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2023-02-08
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem

The codemirror editor within a backend modal has no proper dimensions. An backend user has two scrollbars. one of modal-body and one of the code-mirror.

In such scenario – especially on OS where scrollbars are "hidden" – an user can not consume the whole editor content (e.g. TypoScript, TSconfig, ...).

Open demonstration video

How to test?

Test within e.g. TypoScript module

  1. Open TypoScript
  2. Switch to Active TypoScript submodule
  3. Click on any "Show Code" button which shows more code lines then the height of the modal (more than 1000px to get a good view on the problem)

Suggested solution

Size the codemirror editor to the height of the modal body like shown in the following screenshot

I'm not sure if this small CSS adjustment is the correct solution.


Files


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #101442: t3editor does not show content when appearing in viewportClosed2023-07-25

Actions

Updated by Josef Glatz almost 2 years ago

Actions #2

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78730

Actions #3

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78730

Actions #4

Updated by Jasmina Ließmann 8 months ago

  • Related to Bug #101442: t3editor does not show content when appearing in viewport added
Actions #5

Updated by Jasmina Ließmann 8 months ago

This should have been solved with #101442. Can you please have a look?

Actions #6

Updated by Georg Ringer 5 months ago

  • Status changed from Under Review to Closed

closed as solved

Actions

Also available in: Atom PDF