Bug #99944: FluidEmail should render the parts only once - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Bug #99944

closed

FluidEmail should render the parts only once

Added by Markus Klein almost 2 years ago. Updated 5 months ago.

Status:

Closed

Priority:

Should have

Assignee:

Markus Klein

Category:

Mailer API

Target version:

Start date:

2023-02-13

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

FuildEmail renders its content from within multiple getters.
If the content of the e-mail is changed on purpose from outside, the final call to `ensureValidity` when the mail is sent, throws all the e-mail's content away.

Use-case: e-mail content post-processing from within hooks, like PasswordRecoveryService.
Example: https://gitlab.com/reelworx/typo3/t3-mailservice-demo-project/-/blob/main/packages/demo/Classes/MjmlConnector.php#L57

Solution: generate content only once.

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845

Actions

Copy link

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845

Actions

Copy link

Updated by Markus Klein almost 2 years ago

Testing possibility:

render the html body with $event->getEmail()->getHtmlBody(true)
modify the body
set it again with $message->html($newContent)

Without the patch the modified html body is discarded (overridden).

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78251

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78251

Actions

Copy link

Updated by Markus Klein over 1 year ago

Description updated (diff)

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845

Actions

Copy link

#10

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78251

Actions

Copy link

#11

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845

Actions

Copy link

#12

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78251

Actions

Copy link

#13

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845

Actions

Copy link

#14

Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77845

Actions

Copy link

#15

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78251

Actions

Copy link

#16