Project

General

Profile

Actions
Copy link

Task #100302

closed

ArrayUtility::isValidPath got wrong method signature

Added by Alexander Opitz over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Thomas Hohn
Category:
Code Cleanup
Target version:
12.3
Start date:
2023-03-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.1
Tags:
Complexity:
Sprint Focus:

Description

The functions signature was updated in #97202 probably by using the information from DocBlock which already seams wrong.

The $path argument got "string" as typehint but should have get "array|string" as typehint. The $path argument is only handed over to the getValueByPath method which have "array|string" typehint for the $path argument.

Following code breaks now, if $fieldPointerPath is an array but it makes no sense to transfor this array into string with delims

ArrayUtility::isValidPath($sLangPart, $fieldPointerPath) ? ArrayUtility::getValueByPath($sLangPart, $fieldPointerPath) : null;

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #97202: PHP 8.1 types for ArrayUtilityClosedLarry Garfield2022-03-17

Actions
Actions
Copy link
 #1

Updated by Alexander Opitz over 1 year ago

  • Related to Task #97202: PHP 8.1 types for ArrayUtility added
Actions
Copy link
 #2

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78258

Actions
Copy link
 #3

Updated by Thomas Hohn over 1 year ago

  • Category set to Code Cleanup
  • Assignee set to Thomas Hohn
  • Target version set to 12.3
  • PHP Version set to 8.1
Actions
Copy link
 #4

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78258

Actions
Copy link
 #5

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78258

Actions
Copy link
 #6

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78258

Actions
Copy link
 #7

Updated by Thomas Hohn over 1 year ago

  • Tracker changed from Bug to Task
  • Is Regression deleted (Yes)
Actions
Copy link
 #8

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78258

Actions
Copy link
 #9

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78258

Actions
Copy link
 #10

Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #11

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF