Task #101621
closed
Make frontend meta tag twitter:card optional
100%
Description
The meta tag "twitter:card" should be optional. I would assume that a TypoScript such as page.meta.twitter:card > or page.meta.twitter_card > removes the meta tag in frontend. But this does not work, because ext:seo always add this to the meta tags.
The main problem in my opinion is, that there is no empty/none option to check in Line 84 in /seo/Classes/MetaTag/MetaTagGenerator.php
Its always added.
(Since twitter is X, it should be optional more than ever...)
Updated by Kevin Appelt over 1 year ago
- Status changed from New to Needs Feedback
- Even if we add a check around it, it's most probably set.
twitter_cardis aselectfield with the optionssummaryandsummary_largeand the default ofsummary.
So if nothing is changed, the value will besummary, the condition will become true and the meta tag gets rendered. twitter:cardis still the valid and official meta tag, according to the X Developer Platform (see: https://developer.twitter.com/en/docs/twitter-for-websites/cards/guides/getting-started#started)- AFAIK twitter assumes
summaryif nothing is set, so it wouldn't make a difference to remove it.
What is the specific use case for which you want to remove the meta tag? Maybe this will help to understand the requirement better and offer a solution.
Updated by Patrick Lenk over 1 year ago
Thanks for your feedback. Yes without an none option, the tag is always added. There are many reasons to not force the twitter meta tag. In my case most of them are political or ethical. I just don't want to add anything from this company to my sites anymore. It should just configurable or optional like mostly all other things in TYPO3.
Updated by Gerrit Code Review 9 months ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84622
Updated by Gerrit Code Review 9 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84622
Updated by Georg Ringer 9 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f896c3df6a75ca35ce5da69f5ddb30dc75d6d768.
Updated by Christian Kuhn 9 months ago
- Related to Bug #104097: Also check open graph to decide it twitter:card should be added added
Updated by