Project

General

Profile

Actions
Copy link

Task #101625

open

Simplify GeneralUtility::implodeArrayForUrl

Added by Oliver Klee 9 months ago. Updated 9 months ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2023-08-09
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

From https://review.typo3.org/c/Packages/TYPO3.CMS/+/80247/4#message-6b4a6d09948689295f9467fbb69c930995cd8549:

I wonder if that method cannot be simplified (in another patch, of course) that uses http_build_query() instead of manual array assembling.

Actions
Copy link
 #1

Updated by Oliver Klee 9 months ago

  • Subject changed from Simplify GneralUtility::implodeArrayForUrl to Simplify GeneralUtility::implodeArrayForUrl
Actions
Copy link
 #2

Updated by Stefan Bürk 9 months ago

Small note/hint:

The current implementation ensures a rawurlencode on values in a recursive manner.
This needs to be carefully checked if replaced with `http_build_query()`.

Maybe it makes sense to add special tests for this, if not already contained. (Not checked).

Actions
Copy link

Also available in: Atom PDF