Task #101934
closed
Cleanup code for ContentObjectRenderer::listNum and add tests
100%
Description
- Add unit tests for function ContentObjectRenderer::listNum.
- Improve code by renaming function argument ($char => $delimeter)
- Make sure arguments are always passed as strings (and not null)
(as declared in PHPDoc)
- Improve clarity of description in PHPDoc
In the future typehints can be added for function arguments and
return type.
Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81034
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81034
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81055
Updated by Sybille Peters about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1148fdd3591acb0c6ba1859dbb990dbf08be2df4.
Updated by Christian Kuhn about 1 year ago
- Related to Bug #101925: Check if index exists in stdWrap.listNum to avoid PHP warnings added
Updated by