Project

General

Profile

Actions

Bug #102374

closed

Missing null check in redirect slug update hook

Added by Mathias Brodala about 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Must have
Category:
Link Handling & Redirect Handling
Target version:
Start date:
2023-11-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

With #102140 various instanceof checks where removed. In case of the DataHandlerSlugUpdateHook of EXT:redirects this check also did ensure that unprocessable items are skipped. This is not the case anymore which can cause an error like this:

https://github.com/pagemachine/typo3-flat-urls/actions/runs/6874052335/job/18695061932#step:3:476

Error: Call to a member function withChanged() on null


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #102140: Unneeded pseudo-uncertain instanceof usageClosedBenjamin Franzke2023-10-10

Actions
Actions #1

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81747

Actions #2

Updated by Christian Kuhn about 1 year ago

  • Related to Task #102140: Unneeded pseudo-uncertain instanceof usage added
Actions #3

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81747

Actions #4

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81668

Actions #5

Updated by Mathias Brodala about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack 4 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF