Project

General

Profile

Actions
Copy link

Bug #104398

open

Felogin - ignoring noredirect param

Added by Philipp Parzer about 1 month ago. Updated 27 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
Torben Hansen
Category:
felogin
Target version:
-
Start date:
2024-07-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

https://github.com/TYPO3/typo3/blob/main/typo3/sysext/felogin/Classes/Controller/LoginController.php#L249

in Line 249 it is checked for argument 'noredirect' - but in

https://github.com/TYPO3/typo3/blob/main/typo3/sysext/felogin/Resources/Private/Templates/Login/Login.html#L76

the f:form.hidden has only a name attribute without extbase context (name="noredirect" instead of name="tx_felogin_login[noredirect]")
so the 'noredirect' argument never gets checked

following test works:

|| (isset($this->request->getParsedBody()['noredirect']) && $this->request->getParsedBody()['noredirect'] === '1')

Actions
Copy link
 #1

Updated by Torben Hansen about 1 month ago

  • Status changed from New to Accepted
Actions
Copy link
 #2

Updated by Torben Hansen about 1 month ago

  • Assignee set to Torben Hansen
Actions
Copy link
 #3

Updated by Gerrit Code Review 28 days ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85313

Actions
Copy link
 #4

Updated by Gerrit Code Review 27 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85313

Actions
Copy link

Also available in: Atom PDF