Project

General

Profile

Actions
Copy link

Bug #104398

closed

Felogin - ignoring noredirect param

Added by Philipp Parzer 8 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Torben Hansen
Category:
felogin
Target version:
-
Start date:
2024-07-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

https://github.com/TYPO3/typo3/blob/main/typo3/sysext/felogin/Classes/Controller/LoginController.php#L249

in Line 249 it is checked for argument 'noredirect' - but in

https://github.com/TYPO3/typo3/blob/main/typo3/sysext/felogin/Resources/Private/Templates/Login/Login.html#L76

the f:form.hidden has only a name attribute without extbase context (name="noredirect" instead of name="tx_felogin_login[noredirect]")
so the 'noredirect' argument never gets checked

following test works:

|| (isset($this->request->getParsedBody()['noredirect']) && $this->request->getParsedBody()['noredirect'] === '1')

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #105010: Protect felogin controller isRedirectDisabled()Closed2024-09-17

Actions
Actions
Copy link

Also available in: Atom PDF