Bug #104413: Issue with custom database variable type (ENUM & SET DataTypes) - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

Garvin Hicking

Actions

Copy link

Bug #104413

closed

Issue with custom database variable type (ENUM & SET DataTypes)

Added by Nilesh Malankiya 4 months ago. Updated about 1 month ago.

Status:

Closed

Priority:

Should have

Assignee:

Stefan Bürk

Category:

Database API (Doctrine DBAL)

Target version:

13.3

Start date:

2024-07-17

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

8.3

Tags:

Complexity:

hard

Is Regression:

Sprint Focus:

Description

Issue with command "extension:setup" with composer based setup.¶

Please check attaced stacktrace in attached screenshot.

AFAIK, It was issue with the ext_tables.sql specially for the "ENUM" datatype

CREATE TABLE tx_example_domain_model_scope
(
    scope ENUM('pages', 'seo', 'content', 'translation', 'media', 'techies') NOT NULL,
    iso_code varchar(255) NOT NULL DEFAULT '',
    speech varchar(255) NOT NULL DEFAULT ''
);

It is already working with TYPO3 v12.

Files

image.png (404 KB) image.png

Nilesh Malankiya, 2024-07-17 14:44

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #97498: MariaDB + enum field generates endless DB comparison loop due to wrong/twice string escaping of default value

Closed

2022-04-28

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Stefan Bürk 4 months ago

Status changed from New to Accepted
Assignee set to Stefan Bürk

Actions

Copy link

Updated by Garvin Hicking 4 months ago

Maybe related:
- https://github.com/doctrine/dbal/issues/6465
- http://komlenic.com/244/8-reasons-why-mysqls-enum-data-type-is-evil/

Actions

Copy link

Updated by Stefan Bürk 4 months ago

Related to Bug #97498: MariaDB + enum field generates endless DB comparison loop due to wrong/twice string escaping of default value added

Actions

Copy link

Updated by Stefan Bürk 4 months ago

Subject changed from Issue with custom database variable type to Issue with custom database variable type (ENUM & SET DataTypes)

Actions

Copy link

Updated by Stefan Bürk 4 months ago

Garvin Hicking wrote in #note-2:

Maybe related:
- https://github.com/doctrine/dbal/issues/6465
- http://komlenic.com/244/8-reasons-why-mysqls-enum-data-type-is-evil/

Nope, that issue is not related to the dbal issue - and yes ENUM field types
are evil and should not be used at all.

The described issue is related to Doctrine DBAL 4 upgrade in TYPO3 13.0 and
the fact that the field commenting API has been removed (breaking) OR the added
table normalizations with the upgrade by me. I guess, we need to make a workaround
for the unquotedValues things - or it is again a Dbal 4 removal/breaking change.

Will have a look into that the next days.

Actions

Copy link

Updated by Gerrit Code Review 4 months ago

Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85558

Actions

Copy link

Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85558

Actions

Copy link

Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85558

Actions

Copy link

Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85558

Actions

Copy link

#10

Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85558

Actions

Copy link

#11

Updated by Gerrit Code Review 4 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85558

Actions

Copy link

#12

Updated by Gerrit Code Review 4 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85558

Actions

Copy link

#13

Updated by Gerrit Code Review 4 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85558

Actions

Copy link

#14