Project

General

Profile

Actions

Bug #104433

closed

EXT:form's DataStructureIdentifierListener incorrectly constructs flash messages

Added by Christian Spoo 4 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2024-07-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

`\TYPO3\CMS\Form\EventListener\DataStructureIdentifierListener` has error-handling code in place that catches certain situations in which the listener is unable to modify form plugin's Flexform definitions for certain reasons. It then displays a flash message to indicate this to the BE user. The flash message's text is constructed from a translatable message that currently contains two positional string parameters (being the form's identifier and the message from the exception thrown before).

The persistence identifier happened to be added to the flash message in https://github.com/TYPO3/typo3/commit/9421844a426851dca0771156d8783ad921ce4517. However the `DataStructureIdentifierListener` was never updated accordingly.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #102557: Error message does not contain the the form containing the invalid configurationClosedOliver Bartsch2023-11-29

Actions
Actions #1

Updated by Garvin Hicking 4 months ago

  • Related to Bug #102557: Error message does not contain the the form containing the invalid configuration added
Actions #2

Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85344

Actions #3

Updated by Garvin Hicking 4 months ago

Could you check out the patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/85344 and see if that works? :)

Actions #4

Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85380

Actions #5

Updated by Garvin Hicking 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF