Project

General

Profile

Actions

Feature #104655

closed

Add console command to mark upgrade wizards as undone

Added by Till Hörner 3 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
CLI
Target version:
-
Start date:
2024-08-18
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Problem:
Currently it is not possible to run an already marked as done upgrade wizard from CLI. You have to go to the install tool, mark the wizard as undone and then run it again.

Solution:
Add a new "upgrade:markUndone" command to make it possible to mark an upgrade wizard as undone.

Actions #1

Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85672

Actions #2

Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85672

Actions #3

Updated by Garvin Hicking 3 months ago

From gerrit, crossposted:

Small update: We discussed this internally without a clear consent.

We feel that probably to align with the GUI in the backend it would be more "sane" to reflect functionality there, which means: introduce a "upgrade:markUndone" command.

So, the goal would be to replicate the GUI functionality for the CLI, with the same methodology:

Either execute a wizard
... or mark a wizard as "I don't want this" (like installing EXT:compatibility in the past)
... or "leave it hanging around"

Plus, the GUI allows to mark an executed wizard as undone, so it can be executed again.

Adding a "force" option to this command could trick people into thinking "I add this --force command always, to make sure the wizard runs", but then wizards could accidentally run twice.

What do you or others think?

Actions #4

Updated by Till Hörner 3 months ago · Edited

I think the main point is to make it possible to run an already marked as done upgrade wizard from CLI only. As said before I was used to the --force flag from TYPO3 Console, but I understand the concern and think a separate "upgrade:markUndone" command would be fine too.

Actions #5

Updated by Garvin Hicking 3 months ago

Thanks for your understanding and patience... would you maybe be interested to rework your patch to introduce such a command? :-)

Actions #6

Updated by Till Hörner 3 months ago

  • Tracker changed from Task to Feature
  • Subject changed from Add force option to upgrade:run command to Add console command to mark upgrade wizards as undone
  • Description updated (diff)
  • TYPO3 Version deleted (12)

Yes, I'd like to give it a try ;)

Actions #7

Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85672

Actions #8

Updated by Garvin Hicking 3 months ago

Hi Till,

this is great, thanks so much for the contribution. We'll review it and give feedback on Gerrit, do you get notices/replies there?

Actions #9

Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85672

Actions #10

Updated by Till Hörner 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF