Bug #105009
closed
Title attribute for videos in iframe are not rendered in frontend
100%
Description
I'm using TYPO3 13.3 for testing Youtube videos. If I add a Youtube Video in backend to Media Element the title attribute is not rendered. I test this with original FSC templates.
The title attribute in cms-fluid-styled-content/Resources/Private/Partials/Media/Rendering/Video.html (f:media) is set to {file.title} I tested with an title set in the file properties and set in the file reference. And also just hardcoded text. Nothing works.
On debugging I saw the title attribute is not in the $options in YouTubeRenderer's render function.
I must using additionalAttributes argument for the MediaViewHelper to get the title in frontend.
Updated by Garvin Hicking 2 months ago
- Category set to Fluid Styled Content
(I think I've seen a gerrit patch floating around on this but couldn't dig for it yet)
Updated by Garvin Hicking 2 months ago
- Status changed from New to Needs Feedback
Found it: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68148
Doesn't seem so straight-forward, but maybe you can/want to push it forward?!
Updated by Garvin Hicking 2 months ago
- Is duplicate of Feature #93610: Add video platform name to iframe title for youtube and vimeo added
Updated by Karsten Nowak (undkonsorten) 2 months ago
ยท Edited
I would say, that related issue is not really related to this.
In this issue I describe a completeley missed title attribute. That is more a problem with the MediaViewHelper. Title attribute will not be provided to the render function.
Due to this deprecation https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Deprecation-104223-FluidStandaloneMethods.html
the title Attribute is now placed in $this->additionalArguments.
Updated by Gerrit Code Review 2 months ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86238
Updated by Gerrit Code Review 2 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86238
Updated by Gerrit Code Review 2 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86238
Updated by Karsten Nowak (undkonsorten) 2 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 99e18cc0a72a0e09c8dff318cf6593546387c4b5.
Updated by