Project

General

Profile

Actions

Bug #105009

closed

Title attribute for videos in iframe are not rendered in frontend

Added by Karsten Nowak (undkonsorten) about 1 month ago. Updated 16 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid Styled Content
Target version:
-
Start date:
2024-09-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I'm using TYPO3 13.3 for testing Youtube videos. If I add a Youtube Video in backend to Media Element the title attribute is not rendered. I test this with original FSC templates.
The title attribute in cms-fluid-styled-content/Resources/Private/Partials/Media/Rendering/Video.html (f:media) is set to {file.title} I tested with an title set in the file properties and set in the file reference. And also just hardcoded text. Nothing works.

On debugging I saw the title attribute is not in the $options in YouTubeRenderer's render function.

I must using additionalAttributes argument for the MediaViewHelper to get the title in frontend.


Related issues 1 (1 open0 closed)

Is duplicate of TYPO3 Core - Feature #93610: Add video platform name to iframe title for youtube and vimeoUnder ReviewMartin Kutschker2021-02-28

Actions
Actions #1

Updated by Garvin Hicking about 1 month ago

  • Category set to Fluid Styled Content

(I think I've seen a gerrit patch floating around on this but couldn't dig for it yet)

Actions #2

Updated by Garvin Hicking about 1 month ago

  • Status changed from New to Needs Feedback

Found it: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68148

Doesn't seem so straight-forward, but maybe you can/want to push it forward?!

Actions #3

Updated by Garvin Hicking about 1 month ago

  • Is duplicate of Feature #93610: Add video platform name to iframe title for youtube and vimeo added
Actions #4

Updated by Karsten Nowak (undkonsorten) about 1 month ago ยท Edited

I would say, that related issue is not really related to this.

In this issue I describe a completeley missed title attribute. That is more a problem with the MediaViewHelper. Title attribute will not be provided to the render function.

Due to this deprecation https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.3/Deprecation-104223-FluidStandaloneMethods.html
the title Attribute is now placed in $this->additionalArguments.

Actions #5

Updated by Gerrit Code Review about 1 month ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86238

Actions #6

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86238

Actions #7

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86238

Actions #8

Updated by Karsten Nowak (undkonsorten) about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack 16 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF