Bug #13432: 404 for external links with no redirect - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

internezzo ag

Actions

Copy link

Bug #13432

closed

Feature #13680: Refactor external link, do not follow senseless loop, add user agent

404 for external links with no redirect

Added by internezzo ag over 13 years ago. Updated over 10 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Philipp Gampe

Category:

Linkvalidator

Target version:

Start date:

2011-02-28

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

We get a 404 error when checking www.google.ch. First we thought it might be the bug #12225. But as far as we can see, google.ch is not redirecting anywhere. Could it be, that google is blocking the linkvalidator? Maybe something to do with user-agent string?

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Bug #13547: Special handling for HTTP 400 Bad request

Closed

2011-03-02

Actions

Related to TYPO3 Core - Bug #13756: External links to big files crash TYPO3

Closed

Philipp Gampe

2011-03-10

Actions

Related to TYPO3 Core - Bug #12225: External Links with Redirects are reported as 404

Closed

Philipp Gampe

2011-01-14

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Philipp Gampe over 13 years ago

Maybe something to do with user-agent string?

Possibly, but could be a TYPO3 Bug too.

Do you use curl? (enable_curl use in Install Tool?).

linkvalidator relies on the TYPO3 method t3lib_div::getURL which sometimes seems to return wrong HTTP status codes.

Actions

Copy link

Updated by internezzo ag over 13 years ago

cURL was off. Just enabled it to test. With cURL on, www.google.ch is no longer reported as broken. But we guess this should work with cURL off too?!

Actions

Copy link

Updated by Philipp Gampe over 13 years ago

Then this is a bug in TYPO3 core ... http://bugs.typo3.org/view.php?id=16925

Please make sure all your URLs contain an ending slash "/". So instead of google.ch write google.ch/

Actions

Copy link

Updated by internezzo ag over 13 years ago

URL's with ending slash work, but you can't force customers to enter URL's like that ;)
Thanks for your work Philipp!

Actions

Copy link

Updated by Dmitry Dulepov over 13 years ago

URLs with slash and without slash are technically different URLs. This, for example, is essential on sites made with Lotus Notes. Add slash and you will get a 404. So adding a slash automatically is a wrong solution.

Proper solution would be to check if there is a path in the URL or not. If there is no path ("http://google.ch"), you can append it. However you must not append a slash if the path is given.

Actions

Copy link

Updated by Philipp Gampe over 13 years ago

Status changed from New to Under Review
Assignee set to Philipp Gampe

Thanks for your comment Dmitry. You are right that the "/" needs to be prepended before the path (the HTTP GET) if it is not there already.
But I think this should be handelt by API as linkvalidator only checks the links the user entered.

If this does not get fixed in core we need to do this ourself then and correct the link.

Second problem with this report is, that linkvalidator does not handle HTTP 400 Bad request. It should, so I will open a ticket for it.

Actions

Copy link