TYPO3 Core

The line you are referring to has been commented (prepended with a '#') on 28.01.2004.

Kasper's changelog entry was: "Fixed lots of issues related to safe_mode and open_basedir. Should all work now!".

http://cvs.sourceforge.net/viewcvs.py/typo3/TYPO3core/t3lib/class.t3lib_install.php?r1=1.6&r2=1.7

Could anyone please look into this issue and supply a patch that works for both, normal and open_basedir'ed PHP environments?

cheers,
Ingmar

OK, this is a proposed fix:

In the file t3lib/class.t3lib_install.php (and (if not symlinked) in its duplicate in the typo3/t3lib/ folder) change the following:

Replace the line:

1. if (@file_exists($v) && @is_file($v.$filename.$isExt)) { // file_exists was necessary on windows, because is_file issued a warning if the path was not correct.

With this line:

if (ini_get("safe_mode") || (@file_exists($v) && @is_file($v.$filename.$isExt))) {

That way, if safe_mode is on, the check for the existance of the file would not cause the test to fail, but if it's not enabled, the existance of the file is checked before it's executed. This makes sense to me.

Please confirm if this works for you, Henk Nijveld!

cheers,
Ingmar

Ingmar,

Thanks Ingmar for the response.

This works for me. Why would it not, its the same line as commented with the #, only with a extra check, on save_mode.

I don't know enough from typo3 to tell, that this would not break anything else. Kasper had a reason to change/removing this of course.

regards,
Henk Nijveld

hi ingmar.
The fix didn't work on my typo3 ver. 3.61
running windows 2003 on iis server 6.0 with
php installed as cgi script, PHP version 4.12
imagemagick version 4.29

This is fixed.

Rev. 4890:
Line 1856 in typo3/sysext/install/mod/class.tx_install.php :

if (ini_get('open_basedir') || (file_exists($v)&&@is_file($v.$filename.$isExt))) {

So this is nearly what Ingmar proposed.