Project

General

Profile

Actions

Bug #14174

closed

Extra Message Boundary

Added by Michael Cannon over 20 years ago. Updated over 18 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend API
Target version:
-
Start date:
2004-05-17
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
3.6.1
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The boundary after "$this->constructHTML_media($boundary);" in t3lib_htmlmail::constructHTML() is extra. This causes SPAM filters to add a point or two to scores due to non-matching message boundaries.

Commenting it out resolves the problems.
// $this->add_message("--".$boundary."--\n");

Before:
...
X-Spam-Status: No, hits=3.3 required=5.0 tests=BAYES_44,MIME_BASE64_LATIN,
MIME_BASE64_TEXT,MIME_MISSING_BOUNDARY autolearn=no version=2.63
....
YW1pbHk6IFZlcmRhbmEsIEFyaWFsLCBIZWx2ZXRpY2EsIHNhbnMtc2VyaWY7Cglmb250LXdlaWdo
dDogYm9sZDsKCWZvbnQtc2l6ZTogNDhweDsKCXRleHQtdHJhbnNmb3JtOiB1cHBlcmNhc2U7Cn0K
I3RpbWJ1cm5zIC5zdHlsZTExIHtmb250LXNpemU6IDY1cHh9Cg==

------------part_1_40a8df6a6aa9e--

------------part_1_40a8df6a6aa9e--

After:
X-Spam-Status: No, hits=1.5 required=5.0 tests=BAYES_44,MIME_BASE64_LATIN,
MIME_BASE64_TEXT autolearn=no version=2.63
...
X-Spam-Status: No, hits=1.5 required=5.0 tests=BAYES_44,MIME_BASE64_LATIN,
MIME_BASE64_TEXT autolearn=no version=2.63

(issue imported from #M102)


Files

0000102-class.t3lib_htmlmail.php.diff (750 Bytes) 0000102-class.t3lib_htmlmail.php.diff Administrator Admin, 2004-05-17 18:15
Actions #1

Updated by Ingmar Schlecht over 20 years ago

I'm not so much into MIME stuff, could you enlighten me in which way your patch would make Typo3 generated mails more standard conformant or what 'evil' the line $this->add_message("--".$boundary."--\n"); does?
Do you see any drawback of commenting the line out?

Since this patch is not critical, it will not go into 3.6.2 but instead to 3.7-dev if it will be agreed to by Kasper.

edited on: 17.05.04 22:07

Actions #2

Updated by Michael Cannon over 20 years ago

The After: should look like this
"
....
YW1pbHk6IFZlcmRhbmEsIEFyaWFsLCBIZWx2ZXRpY2EsIHNhbnMtc2VyaWY7Cglmb250LXdlaWdo
dDogYm9sZDsKCWZvbnQtc2l6ZTogNDhweDsKCXRleHQtdHJhbnNmb3JtOiB1cHBlcmNhc2U7Cn0K
I3RpbWJ1cm5zIC5zdHlsZTExIHtmb250LXNpemU6IDY1cHh9Cg==

------------part_1_40a8df6a6aa9e--
"

By the "------------part_1_40a8df6a6aa9e--" being repeated, spam detectors like SpamAssassin and e-mail clients like Microsoft Entourage become confused or mark the e-mail as spam. For SpamAssassin, the MISSING_BOUNDARY rule carries a weight of 1.8 which can be enough to make the newsletter appear to be spam on strict system. A spam score of 5 is pretty strict.

I actually think removing the line entirely would help prevent it's reintroduction versus commenting it out. This is a problem that isn't readily caught in development, but rather under production usage.

Actions #3

Updated by Jan-Erik Revsbech over 20 years ago

I agree, this line should not be there, its a bug. I just deleted the line, and also made a change in formmail that will get it a lower score with SpamAssasin.

I'll upload it into the HEAD of CVS upon Kaspers approval.

/Jan-Erik

Actions #4

Updated by Jan-Erik Revsbech over 20 years ago

It's in CVS now.

Actions

Also available in: Atom PDF