TYPO3 Core

You are right, I think it is better to change Line 610 in class.tslib_pagegen.php to:

$GLOBALS['TSFE']->content.='
<meta name="generator" content="TYPO3 '.$GLOBALS['TYPO_VERSION'].' CMS" />';

(It is also in 3.7RC! !so I think it could be changed until 3.7 final?)

bearbeitet am: 19.09.04 12:00

It has been forgotten! It's still 3.6 here for 3.7-rc1...

No matter, but changing the line in this way would be nicer for current updates..

I have fixed it in the way to set it to <meta name="generator" content="TYPO3 3.7 CMS" />

Actually, I'd also prefer something dynamic, but I don't like $GLOBALS['TSFE']->content.='
<meta name="generator" content="TYPO3 '.$GLOBALS['TYPO_VERSION'].' CMS" />'; because that would also yield the patchlevel version number such as ".1" in "3.6.1".

However, I don't think people should know which patchlevel version of TYPO3 is used, because it can be a hint for security holes.
So if some vulerability will be fixed in the patchlevel release 3.7.1 for example, I think it would be better if the generator tag would just show "3.7" and not "3.7.1" so the visitors would not know if the vulerability is present in that TYPO3 installation.

A dynamic solution that would just five us "3.7" if the TYPO3 version is "3.7.3" would be perfect.
This is not urgent for 3.7 though.

ereg('^([0-9]+\.[0-9]+)',TYPO3_version,$minver);
$GLOBALS['TSFE']->content.='
<meta name="generator" content="TYPO3 '.$minver¹.' CMS" />';

Note: TYPO3_version is a new define added in 3.7.

Or add another define in t3lib/config_default.php:

define('TYPO3_version_min'.'3.7');

Ok the Security reason is a good point.

Then I like the solution with
define('TYPO3_version_min'.'3.7')
it will be better than hardcoded.

because the ereg is too slow and too unflexible.

Minor side-issue:

This might not be the right place to suggest this, but could we not make the inclusion of the tag-closing "/" conditional on the doctype? Some of these hardcoded bits of html keep pages from validating to pre-xhtml standards (e.g. these closing "/"), and others of them keep pages from validating to xhtml standards (e.g. the "wrap" attribute in mailforms => http://bugs.typo3.org/bug_view_page.php?bug_id=0000098)...

edited on: 20.09.04 19:12

Masi suggests:

Or add another define in t3lib/config_default.php:
define('TYPO3_version_min'.'3.7');

I'd prefer this idea! Let's call it the TYPO3_BRANCH. Can be hardcoded, just one line below the TYPO3_VERSION in config_default.php.

While changing this we should also rename the TYPO_VERSION to TYPO3_VERSION (but maybe keep the old one for compatibility reasons).

Does anybody have an idea why the TYPO_VERSION is defined like this:

$TYPO_VERSION = '3.8.0-dev';
define('TYPO3_version', $TYPO_VERSION);

Stucki asks:

Does anybody have an idea why the TYPO_VERSION is defined like this:

$TYPO_VERSION = '3.8.0-dev';
define('TYPO3_version', $TYPO_VERSION);

It used to be only a variable ($TYPO_VERSION), but on my request Kasper added the constant (TYPO3_version).

Reminder sent to ingmar, stucki

I guess this one can be closed now, or?

Cheers,
Andreas

No, not yet. I have now added the TYPO3_branch constant on my dev source, so it can be closed shortly.

@Christopher: If you didn't already, can you please make a new ticket based on your suggestion? Maybe it would be wise to discuss this on the dev list first...

stucki, the bug has already been reported a long time ago in bug #0000236. I put it back on top of the list.

Thanks, Michael, you are right.
I have added the TYPO3_branch constant to CVS HEAD and will close this bug now.