Bug #14429
closed
"Access Key" with umlauts in Firefox
0%
Description
German umlauts like ÄÖÜ don't work as "Access Key" combination in Firefox (and possibly other browsers)
I suggest to allow only [a-zA-Z] as possible "Access Key", tia
(might prevent problems with other charsets too(?))
see attached patch
(issue imported from #M570)
Files
Updated by
Updated by Ingmar Schlecht over 19 years ago
By the way, how does that access key function treat special characters like "/><()[]" currently?
If it just outputs them without piping them thru htmlspecialchars() it'd be non-valid anyway and we'd have to consider it as a real bug that NEEDS to be fixed. Imagine a page title that begins with a quote (")!
TYPO3 would then output something like <.... accesskey=""">.
So how does it treat special chars currently?
Updated by Wolfgang Klinger over 19 years ago
no htmlspecialchars.... that's the line from tslib_menu:
$key = strtoupper(trim(substr($title,$a,1)));
....
$result['code'] = ' accesskey="'.$key.'"';
Updated by Ingmar Schlecht over 19 years ago
right.... Increasing severity to major (though it's easy to fix).
However, I don't have time to commit the fix it right now.
edited on: 23.02.05 16:44
Updated by Wolfgang Klinger over 19 years ago
Hey there's a patch here already, please include it in the upcoming release! Thanks!
Updated by Michael Stucki over 19 years ago
Sorry Rupi dass ich Dir das direkt angehängt habe. Wollte es eigentlich an mich selbst assignen, keine Ahnung was ich falsch geklickt habe...
Kümmerst Du Dich jetzt aber drum?
Liebe Grüsse
- michael
Updated by Rupert Germann over 19 years ago
schon OK ;-)
I committed the patch to CVS a miniute ago.