Feature #14579
closed
error in tslib_fe->getFromCache() with PHP 5
0%
Description
Here is a isset() missing:
if ($this->TYPO3_CONF_VARS['FE']['debug'] || $this->config['config']['debug'])
Should be:
if ($this->TYPO3_CONF_VARS['FE']['debug'] || isset($this->config['config']['debug']))
(issue imported from #M847)
Files
Updated by Ingmar Schlecht over 19 years ago
Ksaper's comment:
This must be something different he means. PHP5 should not give an error
in the first case! Don't fix this or get some more details for me.(The patch will introduce a bug, because
isset($this->config['config']['debug']) evaluates to true if someone set
"config.debug = 0"!!!)
Updated by Karsten Dambekalns over 19 years ago
Martin, any comment on what Kasper wrote?
Updated by Martin Kutschker over 19 years ago
$this->TYPO3_CONF_VARS['FE']['debug'] will always exist, but $this->config['config']['debug'] not. But Kasper is right, the fix is broken.
It should be:
if ($this->TYPO3_CONF_VARS['FE']['debug'] ||
(isset($this->config['config']['debug']) && $this->config['config']['debug'])
)
Updated by Benni Mack about 16 years ago
Is only a cleanup to avoid a NOTICE, but no error. commited to 4.3-trunk.