Project

General

Profile

Actions
Copy link

Bug #14868

closed

xhtml_cleaning cleans HTML comments which is not wanted in any case (working patch included)

Added by Ingo Renner almost 19 years ago. Updated almost 18 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Sebastian Kurfuerst
Category:
Frontend
Target version:
-
Start date:
2005-07-17
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
3.8.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

This problem regards Trackback [1] functionality of weblogs/EXT:timtab. To enable trackback autodiscovery for blog tools a peace of rdf code is place in a HTML comment. This way the page still validates and the trackback URL can be found by other sites automaticly. The rdf code looks like this:

when activating xhtml_cleaning this is transformed to

which can not be discovered by other sites automaticly. Therfore it is necessary to leave HTML comments untouched.

[1] http://www.sixapart.com/pronet/docs/trackback_spec

A working patch is provided is fully backwards compatible and thus should not do any harm to other functionalities. The patch was created against 3.8.0 final.
(issue imported from #M1292)

Files

Download all files
class.t3lib_parsehtml.php.patch (2.4 KB) class.t3lib_parsehtml.php.patch Administrator Admin, 2005-07-17 21:24
class.t3lib_parsehtml.php.patch_v2 (1.4 KB) class.t3lib_parsehtml.php.patch_v2 Administrator Admin, 2005-07-21 23:25
2005-10-18_bugfix_1292.patch (1.41 KB) 2005-10-18_bugfix_1292.patch Administrator Admin, 2005-10-18 09:40
bug_1292_2.patch (977 Bytes) bug_1292_2.patch Administrator Admin, 2005-11-08 22:22

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #14150: t3lib_parsehtml: tags in comments are handled (incorrectly)ClosedChris topher2004-05-11

Actions
Has duplicate TYPO3 Core - Bug #14988: xhtml_cleaning corrupts javascript in HTML-comment from extensionClosed2005-09-22

Actions
Actions
Copy link
 #1

Updated by Sebastian Kurfuerst over 18 years ago

the bugfix_1292.patch fixes the problem (it applies the patch by Ingo), it is only made against current CVS.
Greets, Sebastian

Actions
Copy link
 #2

Updated by Sebastian Kurfuerst over 18 years ago

Hi,
I uploaded an updated version of the patch.
can you please confirm that it still works as expected? I am not fully sure of this...
Greets, Sebastian

Actions
Copy link
 #3

Updated by Sebastian Kurfuerst over 18 years ago

Hi,
I talked about this issue with other core developers, and they have the opinion that the change will make TYPO3 slower. In the long term, xhtml_cleaning should be marked obsolete. The only "workaround" would be right now that you state in your manual that "xhtml_cleaning" is not allowed to be active.

Greets, Sebastian

Actions
Copy link

Also available in: Atom PDF