Project

General

Profile

Actions
Copy link

Bug #14958

closed

typo3/template.php uses id in default table layout

Added by Peter Niederlag about 19 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Peter Niederlag
Category:
-
Target version:
-
Start date:
2005-09-08
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

class template {

var $table_TABLE = '<table border="0" cellspacing="0" cellpadding="0" id="typo3-tmpltable">';

}

Using the template->table($layout='') method will always return a table with this id. While it can of course be ovverriden by providing $layout I still think this should be changed into a class attribute.

Needs thorough checks if any dom-scripting needs the id attribute and css must be changed accordingly.

(issue imported from #M1435)

Actions
Copy link
 #1

Updated by Chris topher over 14 years ago

Same code still present in 4.4beta1.

Actions
Copy link
 #2

Updated by Riccardo De Contardi over 11 years ago

As far as I can see in TYPO3 CMS 4.5.20 the code becomes:

var $table_TABLE = '<table border="0" cellspacing="0" cellpadding="0" class="typo3-dblist" id="typo3-tmpltable">';

In TYPO3 CMS 6.1.0 the code has moved to /typo3/sysext/backend/Classes/Template/DocumentTemplate.php:

public $table_TABLE = '<table border="0" cellspacing="0" cellpadding="0" class="typo3-dblist" id="typo3-tmpltable">';

In both the class attribute is present altogether with the id.

I've also run a grep -H "typo3-tmpltable" ./ -R | cut -d: -f1 from the root of my TYPO3 installation folder (core, of course)
And the results are:
for TYPO3 4.5.20:

./typo3/template.php

and for 4.6.1:
./typo3/sysext/backend/Classes/Template/DocumentTemplate.php

So I guess this issue could be closed;)

Actions
Copy link
 #3

Updated by Alexander Opitz over 11 years ago

  • Status changed from Accepted to Closed
  • Target version deleted (0)
Actions
Copy link

Also available in: Atom PDF