Bug #15707: Page highlighting for alt_db_navframe - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #15707

closed

Page highlighting for alt_db_navframe

Added by Michiel Roos over 18 years ago. Updated almost 11 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Michael Stucki

Category:

Workspaces

Target version:

Start date:

2006-02-23

Due date:

% Done:

Estimated time:

TYPO3 Version:

4.0

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

When using workspaces, the value $this->doHighlight is set to false. This breaks the highlighting of the current page. The reason that this is done is because the current row highlighting javascript works directly on the background color of the row. It is however more elegant to not disable doHighlight for workspaces, but to change the highlighting javascript to add or _subrtract a css classname for the current TR.

This makes it possible to choose your own highlighting style in your css file, for example by giving the image (which has class c-recIcon) a background:

.hilightRow .c-recIcon {
background-image: url(../backgrounds/icon.shadow.gif);
background-position: bottom center;
background-repeat: no-repeat;
text-decoration: none;
}

// Remove old:
    theObj = document.getElementById(top.fsMod.navFrameHighlightedID[frameSetMod+ule]);
    if (theObj) {
      theObj.className=theObj.className.replace("hilightRow", "");
    }

// Set new:
    top.fsMod.navFrameHighlightedID[frameSetModule] = highLightID;
    theObj = document.getElementById(highLightID);
    if (theObj) {
      theObj.className=theObj.className+" hilightRow";
    }

(issue imported from #M2677)

Files

Download all files

navFrame.patch (2.01 KB) navFrame.patch		Administrator Admin, 2006-12-13 17:25
bug_002677.patch (2.67 KB) bug_002677.patch		Administrator Admin, 2007-02-07 17:18

Actions

Copy link

Updated by Michiel Roos over 18 years ago

Oops . . .
For clarity. . . .

The code resides in typo3/alt_db_navframe.php, function init(): (line 249 - 270)

Cheers

Actions

Copy link

Updated by Administrator Admin over 18 years ago

Usability improvement for 4.5
We need to find out how we will officially both highlight a row and display that it has versions.
But I agree that it is confusing and annoying not to have the rows highlighted in the workspace.

Actions

Copy link

Updated by Martin Kutschker over 18 years ago

A tiny visual hint is to underline the current page.

I think we should not delay real usability issues to the next version, which may be way off. Making the hikighting work is not a new feature but a bug fix.

Actions

Copy link

Updated by Martin Kutschker almost 18 years ago

The patch navFrame.patch uses a navFrameHL for LIVE abd navFrameHL-WS for all other workspaces using the above method for multi-classing.

Additionally it sets the style for te current page to top and bottom borders and bold.

It may easily be changed to use differnt HL for LIVE and the rest.

Actions

Copy link

Updated by Benni Mack almost 18 years ago

The new patch works with typo3 4.1 and adds the following:

live-workspace: "active" as class
workspaces: "active active-ws wsverXX" (XX for workspace ID)

with that you get:

a) all workspaces have "active", so they are highlighted out of the box.
b) if you want to change the color for the workspaces other than Live, style with "active-ws"
c) if you want to have a different color for every single workspace, you can do this with the wsver-1 or whatever.

What do you think?

Actions

Copy link