TYPO3 Core

Still present in RC2.

Ernesto, I just assigned this bug to you, maybe you could integrate a fix for this into your imgtext related css_styled_content patch.

cheers
Ingmar

@Ingmar,

I would rather start a new patch here, once the previous has been commited. Fixing too many things with one patch doesn't help if we later want to "undo" some change or see what changes one particular fix did.

I agree.

Attached patch fixes the problem (which has always been there in css_styled_content). The rendering of a a "Divider" will do the same that is being done in content(default): no output at all. If someone thinks this should be changed, please discuss in typo3.teams.content-rendering.

Patch is intended to be applied after the other IMGTEXT fixes (see bug #2995), but should also work with current CVS version.

Please review attached patch.

Thanks, will do.

cheers
Ingmar

In RC3 the error disappeared, but in the FE the content element is still empty:

        <a id="c22"></a>

Hi Bjoern,

but isn't that the correct behaviour?

Has the divider been rendered in older versions of TYPO3?

cheers,
ingmar

@Björn Heggemann, if you want to output something there, you can add something like this to your TypoScript:

tt_content.div >
tt_content.div = TEXT
tt_content.div.value = <hr />

Sorry, I haven't tested the behavior in older versions.

Shouldn't the output, as Ernesto proposed, be the default setting? Otherwise it would be another Gremlin ;)

I think this is a matter of taste and you will get different opinions on that.

But you are right that it makes little sense to have a "Divider" content element which does nothing. So either we drop this content element or output something meaningful with it.

But either way we must be aware that there might be people already using this in their TypoScript templates, so changing the default behaviour might lead to unforseen results. Which is why such changes have always been considered with care. So I think if we change this, we'll do that in 4.1/4.5 and in a TypoScript part with a condition that tests the compatVersion.

@Ernesto: This sounds good to be. Meanwhile it would be a good idea to add a notice in the ts_ref with the code you proposed.

Ok. I think TSref is not the right place to document that, but rather css_styled_content docu. The CSC-docu has to be updated anyway. Will do that when I have some time and I'll add this information somewhere. Thanks for your comments, Bjoern.

I'll keep this bug report open with "acknoledged" status so I can remember that when the time comes.

Hi Ernesto!

May I remember you to add the changes to 4.1 - I heared the next release is in sight ;-)

Hi Ernesto!

Will this issue be resolved in 4.1 as you promised?

Regards
Bjoern Kraus

Björn,

when did Ernesto make any promises? I couldn't find any! :-)

Anyway, this change is a very small one. If the div element still throws a rendering error(?) then we just need to fix that. However, changing the default content to something other than blank cannot be done at this time.

- michael

Hi Michael!

No, the error is gone since RC3 as I wrote before.

Ernesto wrote:
"So I think if we change this, we'll do that in 4.1/4.5 and in a TypoScript part with a condition that tests the compatVersion. "

IMHO a divider that doesn't do anything than just beeing a blank content element is still bogus. We had this Zap the Gremlins campaign to ease the use of TYPO3. I think this issue should be a late part of that or at least an ealry part of the next level (4.1/4.5). Ernesto's proposal sounds good. Why shouldn't this find a way in 4.1 - as you can see the report and the discussion is nearly one year old ...!

Regards
Bjoern

http://www.phoenix-medien.de

Michael, is it possible to have this change in 4.2 in the way Ernesto described it?

Hi Björn,

you are invited to write a patch against latest trunk that implements the behaviour as described. Whether the patch will then be accepted, is then up to the reviewers to decide.

For details, see the http://news.typo3.org/news/article/core-development-mailinglist-now-open-for-community-involvement/ and the rules page.

cheers
Ingmar

committed to trunk, rev 5593