Project

General

Profile

Actions

Bug #16430

closed

Permissions not set on extracted localization-files

Added by Andreas Wolf over 18 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Category:
Extension Manager
Target version:
-
Start date:
2006-08-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When you let the Extension Manager update translations of extensions, the unzipped files in typo3conf/l10n/<lang-key>/ are not checked for the right permissions as set in fileCreateMask, folderCreateMask and createGroup.

The problem with this is that the function t3lib_div::fixPermissions doesn't change the permissions of folders. There is also no function to recursively change permissions of files, as would be neccessary for the function. I have created to new functions in t3lib_div, fixPermissionsFolder() and fixPermissionsRecursively(), which do exactly these two tasks. I also introduced a call to fixPermissionsRecursively in typo3/mod/tools/em/class.em_index.php to fix the permissions after extracting all downloaded zip-files.

Please see the attached patch-file for the changes.

(issue imported from #M3977)


Files

3977.patch (2 KB) 3977.patch Administrator Admin, 2006-08-04 13:40
3977_2.diff (2.55 KB) 3977_2.diff Administrator Admin, 2008-07-25 18:58
bug_3977_v3.diff (5.04 KB) bug_3977_v3.diff Administrator Admin, 2010-04-17 23:21
3977_v5.diff (4.92 KB) 3977_v5.diff Administrator Admin, 2010-04-24 16:35
3977_v5_test.diff (12.3 KB) 3977_v5_test.diff Administrator Admin, 2010-04-24 16:35
3977_v6.diff (4.92 KB) 3977_v6.diff Administrator Admin, 2010-04-26 13:55
3977_v6_test.diff (12.3 KB) 3977_v6_test.diff Administrator Admin, 2010-04-26 13:55
Actions #1

Updated by Ingmar Schlecht over 16 years ago

Another suggestions:

I would go with only one function t3lib_div::fixPermissions() that does it all: It should handle files, folders, and have an additional $recursive flag.

- Ingmar

Actions #2

Updated by Andreas Wolf over 16 years ago

I have changed the patch according to your suggestion, Ingmar, and also made it apply seamlessly to the current trunk. Please see 3977_2.diff for the new patch.

Actions #3

Updated by Lars Houmark over 14 years ago

I can confirm that this bug is still existing, and have uploaded a patch that applies to current trunk and the 4.3 branch.

RFC posted to the core list.

Hopefully this time this one will make it in.

Actions #4

Updated by Christian Kuhn over 14 years ago

  • Committed _v6 to trunk rev. 7430
  • Committed _v6_test to trunk rev. 7431
Actions

Also available in: Atom PDF