Project

General

Profile

Actions

Bug #16808

closed

setHeaders in class.t3lib_htmlmail forget to quote the realname parts of the "From" and "reply-to" headers

Added by Bernd Hanisch almost 18 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Communication
Target version:
-
Start date:
2006-12-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

the function setHeaders dont quote the realname parts of this mail addresses. Some times user input a comma in input fields of forms. if now autoreplay scripts pass the "from" adress back to a mailserver this miss interpret the mail address and split it to 2 recipients.

Bugfix for that is simple quote the realname parts like patches below:

line: 460:
$this->add_header('From: "'.$this->from_name.'" <'.$this->from_email.'>');

line: 468:
$this->add_header('Reply-To: "'.$this->replyto_name.'" <'.$this->replyto_email.'>');

(issue imported from #M4692)


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #21668: Wrong mail encodingClosed2009-11-24

Actions
Actions #1

Updated by Thorsten Kahler over 17 years ago

For mail forms this is fixed TYPO3 4.0.5 and 4.1RC2. Extensions using t3lib_htmlmail should always check the data submitted and e.g. quote names if necessary.

Although adding some built-in security to t3lib_htmlmail is still a point to discuss.

Actions #2

Updated by Andreas Otto † over 16 years ago

Also have a look at http://www.php.net/manual/en/function.mail.php section "notes" which tries to explain where the mail function implementation in PHP differs on Windows. Which is why your solution might break sending mails with TYPO3 on Windows.

Actions #3

Updated by Christian Kuhn over 15 years ago

Resolved, no change required:

Proper quoting needs to be done manually in code using this API, for core this is done.

Actions #4

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF