Project

General

Profile

Actions

Bug #17185

closed

GIFBUILDER TEXT antiAlias=0 doesn't work with black texts

Added by Jo Hasenau over 17 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Documentation
Target version:
-
Start date:
2007-04-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If you set antiAlias=0 for TEXT objects in GIFBUILDER usually this should disable antialiasing, which is essential if you are rendering pixel fonts. Unfortunately this doesn't work if the fontColor is set to black (or #000000).

Reason: The PHP function ImageTTFText() is expecting a negative value to disable Freetype antialiasing.
In class.t3lib_stdgraphic.php this is done by the following line (608)

$Fcolor = $conf['antiaAlias'] ? $Fcolor : -$Fcolor;

Which will leave $Fcolor as is if it's value is zero, since -0 will still be 0.

There are two options to solve this issue:
1. Change TSref and tell people that hey have to use at least #000001 as fontColor to disable antialiasing
2. Change the code to work like this:

$Fcolor = $conf['antiaAlias'] ? $Fcolor : ($Fcolor==0 ? -1 : -$Fcolor);

(issue imported from #M5355)

Actions #1

Updated by Alexander Opitz over 11 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (0)

The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #2

Updated by Jo Hasenau over 11 years ago

It's still valid, but the file and the line have changed.
It's in line 665 TYPO3\CMS\Core\Imaging\GraphicalFunctions.php

Actions #3

Updated by Alexander Opitz over 11 years ago

I looked in the doc of the PHP function and I think we should note it in the documentation.

Would that be ok for you?

Actions #4

Updated by Jo Hasenau over 11 years ago

A hint in the docs would be enough - but the value mentioned there has to be # 000001 without the space.
The issue tracker made a link to an issue out of that value.

Actions #5

Updated by Alexander Opitz over 11 years ago

As you are member in the TSref Team, will you do this?

Actions #6

Updated by Alexander Opitz about 11 years ago

  • Category set to Documentation
  • Status changed from Needs Feedback to New
  • Is Regression set to No
Actions #7

Updated by Mathias Schreiber almost 10 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Jo Hasenau

@Joey:
could you direct-edit this on github, please?

Actions #8

Updated by Jo Hasenau almost 10 years ago

Could you please add bunnyfield as user to the repo?

Actions #9

Updated by Chris topher over 9 years ago

Jo Hasenau wrote:

Could you please add bunnyfield as user to the repo?

You are now a collaborator. You can edit the docs now! Go ahead!

Actions #10

Updated by Alexander Opitz over 9 years ago

Is this issue done?

Actions #11

Updated by Riccardo De Contardi over 9 years ago

as far as I can see in the online documentation http://docs.typo3.org/typo3cms/TyposcriptReference/Gifbuilder/ObjectNames/Index.html this is not mentioned.

Actions #12

Updated by Riccardo De Contardi about 9 years ago

  • Status changed from Needs Feedback to New
Actions #13

Updated by Riccardo De Contardi over 8 years ago

  • Status changed from New to Closed
  • Assignee deleted (Jo Hasenau)

The documentation has been updated - see http://docs.typo3.org/typo3cms/TyposcriptReference/Gifbuilder/ObjectNames/Index.html

I close this issue for now; if you think it is the wrong decision, please reopen it or add a new issue with a reference to this one. Thank you.

Actions

Also available in: Atom PDF