TYPO3 Core

If I read the patch correctly for headers the characters = and ? are not encoded. Which is wrong BECAUSE these are used to signify charset and encoding.

The attached diff shows clearly that the encoded string is to be used WITHIN a =?charset?Q?...?= construct.

So I fail to see a) the original problem and b) how the "fix" is any better. In fact I think the patch is wrong.

For me the patch works.

But indeed it doesn't reach far enough. According to RFC 2047 5 [1]. "encoded-word"s are not allowed in all header fields. The current interface of t3lib_div::encodeHeader() has to be extended to enable that distinction.

I'm currently working on a new patch which adds an optional parameter to the interface of t3lib_div::encodedHeader() and uses the "best available" PHP function to encode the header line. IMO it should prefer the function that's pointed out by TYPO3_CONF_VARS[SYS][t3lib_cs_convMethod].

[1] http://www.faqs.org/rfcs/rfc2047.html

Maybe it would help, if you posted input and expected and actual output. Neither from this bug entry nor frrom the patch I'm able to see what went wrong for you.

Hi Masi,

please try these lines:

<?php
$headerline1 = 'Is this line wrong? Yes!';
$headerline2 = 'Is this line wrong? No!';
include('t3lib/class.t3lib_div.php');
$preferences = array('scheme'=>'Q', 'input-charset'=>'iso-8859-1', 'output-charset'=>'iso-8859-1');
echo ( iconv_mime_encode( 'subject', $headerline2, $preferences ) );
// subject: =?iso-8859-1?Q?Is=20this=20line=20wrong=3F=20No!?=
echo ( t3lib_div::encodeHeader(  $headerline1, 'quoted-printable', 'iso-8859-1 ) );
// Is this line wrong? Yes!
?>

IMHO there is no need to quote all occurences of ? and =. iconv_mime_encode() is overeager. Why should a standalone ? be quoted? What MUST be quoted is a starting sequence of =?. t3lib_div::encodedHeader() fails in fact to do so.

As = is correctly quoted for quoted-printable nothing needs to be done here.

So it is sufficient to trigger the encoding when a non ASCII character is found or the string contains a =? sequence. Change the check at the top of t3lib_div::encodedHeader() like this:

if (!preg_match('/[^'.chr(32).'-'.chr(127).']/',$line) && ($enc=='base64' || strpos($line,'=?')===FALSE)) return $line;

Note that the header will not be encoded at all if it contains ###!