Project

General

Profile

Actions

Bug #17380

closed

Extension Manager does not recognize and report errors when executing sql queries

Added by Christoph Eisenmann over 16 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extension Manager
Target version:
-
Start date:
2007-07-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

No error message is given if something in ext_tables_static+adt.sql went wrong
A malfunctioning create table or insert into statement is not recognized. The extension manager reports extension installed even important parts like data are missing.

It is always possible that an extension has a sql bug. In this case an error message should be given.

(issue imported from #M6008)


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #16219: Creating Admin user doesn't check for correct DB-ConnectionClosed2006-06-07

Actions
Actions #1

Updated by Ernst Went almost 16 years ago

Quickpatch to solve the problem:
open typo3/mod/tools/em/class.em_index.php,
move to the function checkDBupdates, look for the line
$GLOBALS['TYPO3_DB']->admin_query($statements_table[$table]);
(line no. 4479 and add this underneath:
if($e = $GLOBALS['TYPO3_DB']->sql_error()) $error = "<div><b>A SQL-error was thrown by statements in the file 'ext_tables_static+adt.sql'</b><br />$e</div>";

A few lines further down find the line
$GLOBALS['TYPO3_DB']->admin_query($v);
and add
if($e = $GLOBALS['TYPO3_DB']->sql_error()) $error = "<div><b>A SQL-error was thrown by statements in the file 'ext_tables_static+adt.sql'</b><br />$e<br><b>Statement:</b><br />$v</div>";

At last add at the end of the foreach-block (above the else statement, line no 4492):
if($error) $content .= $error;

Linenumbers apply to TYPO3 Version 4.1.2

Actions #2

Updated by Chris topher almost 14 years ago

Someone to write a patch? Ernst?
Please put the texts in locallang files then (as it is everywhere else in EM, too).

Actions #3

Updated by Alexander Opitz over 10 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (0)
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #4

Updated by Alexander Opitz about 10 years ago

  • Status changed from Needs Feedback to Closed

No feedback within the last 90 days => closing this ticket.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions

Also available in: Atom PDF