TYPO3 Core

Peter, Thanks for the extensive bug description and the patch. I just hit that problem as well and tracked it down further. It's not a Gentoo-specific problem (we just got hit by it first as we are packaging this snapshot).
It was this commit: http://cvs.php.net/viewcvs.cgi/php-src/sapi/cgi/cgi_main.c?r1=1.267.2.15.2.42&r2=1.267.2.15.2.43&pathrev=PHP_5_2 (Fixed bug #40419 (Trailing Slash in CGI request don't work)).
I think this is a pretty important behaviour change and may have been unintended. Please report such changes/bugs to our bugzilla (http://bugs.gentoo.org) if you are not sure whether it is Gentoo-specific and in any other cases to http://bugs.php.net/
Thanks.

Also, I just sent a mail to Dmitry (who made that commit), CCing Ilia (5.2 RM) to make sure this is really intended. If it is, your patch should probably applied as a lot of installations are likely to break otherwise.

Current status is that this bug will probably not fixed for 5.2.4, but in a later version...
Including Peter's patch into the official Typo3 source would probably be a good idea since it will be a long time to 5.2.5, I guess.

The link to the PHP bug:
http://bugs.php.net/bug.php?id=40419

The C-patch shows that it only happens if cgi.fix_pathinfo in php.ini is enabled.

From http://www.php.net/manual/en/ini.core.php:
<b>cgi.fix_pathinfo boolean</b>

Provides real PATH_INFO/PATH_TRANSLATED support for CGI. PHP's previous behaviour was to set PATH_TRANSLATED to SCRIPT_FILENAME, and to not grok what PATH_INFO is. For more information on PATH_INFO, see the cgi specs. Setting this to 1 will cause PHP CGI to fix it's paths to conform to the spec. A setting of zero causes PHP to behave as before. Default is zero. You should fix your scripts to use SCRIPT_FILENAME rather than PATH_TRANSLATED.

Thanks to Peter for providing a workaround. However, I'm not sure if this could have any side effects. And even if not, it's clearly a PHP bug which will hopefully get fixed quite soon.

I suggest to leave this patch out of TYPO3core and patch affected installations manually until PHP has fixed the issue.

Reopening this bug to make it possible to add more comments on this.

What about only doing the chdir(PATH_site) only for the specific PHP versions affected:

Pseudo code:
if(php version > 5.2 && cgi.fix_pathinfo) {
chdir(PATH_site);
}

Agreed. Who's gonna update the patch?

Dmitry (Zend) asked me to open a php bug, so I filed http://bugs.php.net/bug.php?id=42587

Until now I didn't manage to get Typo3 working without patching PHP (i.e. above patch doesn't work for me). I'll try to track it down further.

Really too lazy to dig through the whole Typo3/TS/TemplaVoila code, I'm now using the simplest workaround: Don't use a index.php symlink, just copy the file from typo3_src/. Shouldn't cause too many problems with updates as this file doesn't look like it's subject to heavy changes.

Here is the code:

if (version_compare(PHP_VERSION, '5.2', '>') && ini_get('cgi.fix_pathinfo') == '1')
chdir(PATH_site);

@Michael:
If you agree with this I will post a patch file for it.

So Chrstian says that you can work around the issue while Björn prefers the fix. What should we do?

As I posted on the list, the php.ini setting doesn't work for me running php as fastcgi. The fix seems to be the only solution that works for all configurations.

The php bug has been fixed in svn (see http://bugs.php.net/bug.php?id=40419 ). Perhaps someone can give it a try.

The fix from php-cvs works for me. Anybody who hits the problem should just apply http://cvs.php.net/viewcvs.cgi/php-src/sapi/cgi/cgi_main.c?r1=1.267.2.15.2.48&r2=1.267.2.15.2.49&pathrev=PHP_5_2 and recompile...
For Gentoo, we are going to include this patch in our next revision (php-5.2.4-r1).

I'm currently testing the new PHP version. The bug seems to be fixed in PHP 5.2.5. There is no patching of index.php needed anymore.

I can confirm this on PHP 5.2.4-2+b1/Debian with fcgid.

Summary: This PHP bug was introduced in 5.2.4 and fixed in 5.2.5.
However, Debian delivers 5.2.4-2+b1 which still contains this bug.
The behaviour only occours if cgi.fix_pathinfo is set (thus CGI mode only), as it can be seen in sapi/cgi/cgi_main.c.

The attached patch checks the PHP versions, the PHP setting and if the current directory is different to PATH_site. If these conditions are met, the chdir(PATH_site) is executed.

Had logical bug in first patch. New version attached.

Debian/Testing has now "PHP 5.2.5-2" which doesn't have the PHP bug anymore.
Since there is not much feedback concerning this issue anymore, I tend to drop the RFC in the Core List. But whoever it needs the patch is still here in the bugtracker.

I can confirm this issue with the php5-cgi (5.2.4-2ubuntu5) version, that is delivered with Ubuntu 8.04 Hardy Heron.

Setting cgi.fix_pathinfo = 0 in the php.ini file fixes it.

I think that this is closely related to bug #14692 and although it's not exactly the same problem, it could likely be solved with the same change.

I never liked the way of chdir()'ing into PATH_site, I rather think that non-absolute paths are wrong and need to be fixed.

Please check if the patch in #14692 solves your problem as well.

This issue is dropped since it was a work-around for a PHP misbehaviour.