Project

General

Profile

Actions

Bug #18549

closed

Problems using link wizard in content elements

Added by Andreas Otto † almost 16 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
-
Target version:
-
Start date:
2008-04-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Users were used to add a link to e. g. the header of a content element
(Bild 1.png).

If you click on the link wizard icon a new window opens and shows the
link wizard (Bild 2.png). The tab "External URL" is active. The field
URL is pre-filled with the host address of the host TYPO3 is running on.

Write a different URL into the field URL now (Bild 3.png) and click "Set
Link".

Back in the content element (Bild 4.png) you will see that the field
"Link" indicates that it was changed, but the field is empty.

I think this is a bit strange.

Tested with 4_2 branch on Firefox 2.0.0.13 on Mac OS X 10.5.

Branch 4_1 also does not work correctly.

(issue imported from #M8001)


Files

Bild 1.png (565 KB) Bild 1.png Administrator Admin, 2008-04-03 11:36
Bild 2.png (26.1 KB) Bild 2.png Administrator Admin, 2008-04-03 11:36
Bild 3.png (56.2 KB) Bild 3.png Administrator Admin, 2008-04-03 11:36
Bild 4.png (10.9 KB) Bild 4.png Administrator Admin, 2008-04-03 11:37
8001_4.2.patch (8.45 KB) 8001_4.2.patch Administrator Admin, 2008-04-05 15:13
8001_v2.diff (14.2 KB) 8001_v2.diff Administrator Admin, 2008-04-06 00:38
8001_v3.diff (14.2 KB) 8001_v3.diff Administrator Admin, 2008-04-06 11:56
8001_v4.patch (15.5 KB) 8001_v4.patch Administrator Admin, 2008-04-07 09:06
8001_v5.patch (16.1 KB) 8001_v5.patch Administrator Admin, 2008-04-07 10:56
8001_v6.patch (16.1 KB) 8001_v6.patch Administrator Admin, 2008-04-07 12:25
8001_w-folder-select.patch (19.8 KB) 8001_w-folder-select.patch Administrator Admin, 2008-04-07 14:25
8001-safari-fixed.patch (20.4 KB) 8001-safari-fixed.patch Administrator Admin, 2008-04-11 16:25
8001-cleaned-n-updatebutton.patch (21.1 KB) 8001-cleaned-n-updatebutton.patch Administrator Admin, 2008-04-15 03:49
8001-ie6-fixed.patch (21.2 KB) 8001-ie6-fixed.patch Administrator Admin, 2008-04-15 20:36

Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #14135: link wizard fails to remember external linksClosedBenni Mack2004-05-02

Actions
Related to TYPO3 Core - Bug #18037: Problem with PopUp- Size on IE Browser at typo3/class.browse_links.phpClosed2008-01-21

Actions
Has duplicate TYPO3 Core - Bug #18193: When opening the "link-wizzard" external Url is prefilled with http://thebaseurl/?id=ClosedChris topher2008-02-12

Actions
Actions #1

Updated by Andreas Otto † almost 16 years ago

Using the link wizard which is provided by the htmlarea rte causes no problems.
But htmlarea rte is using a different class for the link wizard afaik.

Actions #2

Updated by Steffen Kamper almost 16 years ago

the link wizard in general is broken - same happens in Image option with link wizard

Actions #3

Updated by Ralf Hettinger almost 16 years ago

Is (at least) related to #14135

Actions #4

Updated by Andreas Otto † almost 16 years ago

Related to #14135.

Actions #5

Updated by Steffen Kamper almost 16 years ago

it's broken in 4.2 initial version as well

Actions #6

Updated by Ralf Hettinger almost 16 years ago

I've created a patch for 4.2 that should solve the problems of #18549 (this one... which is a due to namespace congestion of JS functions) and #18549 (which is reconnection of link type not properly implemented for the wizard). Furthermore it completes #18549 (new link type folder wasn't implemented for the link wizard).

Will submit it to core list in a minute...

... at the moment, I haven't got the time to backport it to 4.1 - maybe that'S a nice task for so else? ;)

Actions #7

Updated by Steffen Kamper almost 16 years ago

I did some improvements in 8001_v2.diff

Actions #8

Updated by Steffen Kamper almost 16 years ago

ther was a typo and ad a small issue with empty link params, please use 8001_v3.diff

Actions #9

Updated by Ralf Hettinger almost 16 years ago

added 8001_v4.patch, which
- solves #14135 again,
- handles title, class and target for all types,
- reimplements the update button

Actions #10

Updated by Ralf Hettinger almost 16 years ago

thanks to Steffen Kamper for testing.

Added in 8001_v5.patch:
- current link is saved if changing the tab
- cosmetic correction of email address field

Actions #11

Updated by Ralf Hettinger almost 16 years ago

8001_v6.patch is just a slight bugfix of _v5

Actions #12

Updated by Ralf Hettinger almost 16 years ago

8001_w-folder-select.patch now
- handles content of the tab 'folder' better (i.e. lists folders)
- has current tab set to 'page' and no current link set, if no link set yet.

Actions #13

Updated by Steffen Kamper almost 16 years ago

... and should be the last one, as all is fixed now - thx Ralf!

Actions #14

Updated by Andreas Otto † almost 16 years ago

Well, I don't think so.

I have just applied the patch to Revision 3552 on branch 4.2 and tested on Safari.

If no link is set, the the wizard starts in the page tab.

Selecting another tab is not possible.

If I enter a URL in the link field of the record and save the record the wizard will use the tab external link.

Again, selecting another tab is not possible.

Actions #15

Updated by Steffen Kamper almost 16 years ago

i confirm that on safari only (tested the windows version)

But i don't understand the behavior, as the JS-Part here is not accessed by Safari (jumpToUrl(...) )

is there a possibiolity to debug the js to see whats going wrong?
Does it work in RTE ?

Actions #16

Updated by Andreas Otto † almost 16 years ago

Don't know how to use the Developer tools in Safari.

The link wizard in RTE is working fine.

Actions #17

Updated by Ralf Hettinger almost 16 years ago

Guys,

this one was admittedly a bit hard to track down (Safari JS engine chokes on reserved word class used as variable)...

... please use 8001-safari-fixed.patch

Actions #18

Updated by Ralf Hettinger almost 16 years ago

Two more references: #18193 #18193
The more bugs to close, the more fun, i'd think ;)

Actions #19

Updated by Ralf Hettinger almost 16 years ago

8001-cleaned-n-updatebutton.patch
- is rather clean according the CGL (thanks to Ingo Renner for taking care of this)
- is more consistent on when showing the "update" button (thanks Andreas Otto for the hint)

Actions #20

Updated by Ralf Hettinger almost 16 years ago

8001-ie6-fixed.patch
- bugfix: unselectable target in IE 6 due to multiple usage of same identifier in HTML source

Actions #21

Updated by Ingo Renner almost 16 years ago

committed to SVN

Actions

Also available in: Atom PDF