Project

General

Profile

Actions
Copy link

Bug #19371

closed

Code in typo3/sysext/lang/lang.php don't match with the CGL

Added by Stefano Kowalke about 16 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Benni Mack
Category:
-
Target version:
-
Start date:
2008-09-23
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Code in file typo3/sysext/lang/lang.php don't match with the Coding Guidlines.

  • Add spaces
  • changing boolean '0' to 'false'
  • changing boolean '1' to 'true'
  • remove reset() before foreach()
  • remove 'var', take public or protected instead
  • Array() -> array()
  • while(list() = each()) -> foreach()
  • global $TCA_DESCR; -> $GLOBALS['TCA_DESCR']
  • switch: remove 'break' in default case *

(issue imported from #M9416)

Files

lang.php.diff (18.1 KB) lang.php.diff Administrator Admin, 2008-09-23 22:19

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #22988: Change language::readLLfile() from protected to publicClosed2010-06-24

Actions
Actions
Copy link
 #1

Updated by Christian Kuhn over 15 years ago

Resolved with Resolution won't fix:

Even if a new CGL has been decided now, this single RFC won't make it to the core as we need a far better solution so clean up (ideally) all files in one shot. Some single changes to one or the other file won't help much.

Actions
Copy link
 #2

Updated by Benni Mack over 14 years ago

committed v4 to trunk (rev. 7650).

Actions
Copy link
 #3

Updated by Susanne Moog over 13 years ago

  • Target version deleted (4.4.0)
Actions
Copy link

Also available in: Atom PDF