Project

General

Profile

Actions

Bug #20161

closed

Invalid XHTML Code in logout form

Added by Stefan Lang over 15 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
felogin
Target version:
-
Start date:
2009-03-11
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The Logoutform ist invalid by w3c specification. There're ampersands in the code. The Form-Tags looks like this:
<form action="page.html?&page=" target="_top" method="post">

To get xHTML validation it must be:

<form action="page.html?&_amp;page=" target="_top" method="post">

(without underscore) so & must be &_amp;

I've located the problem in typo3/sysext/felogin/pi1/class.tx_felogin_pi1.php nearly line 569 and line 575.

Please fix this bug in one of the next versions of TYPO3, so I don't have to fix it by myself at every new update.

(issue imported from #M10663)


Files

felogin.patch (622 Bytes) felogin.patch Administrator Admin, 2009-03-19 12:08
0010663.patch (548 Bytes) 0010663.patch Administrator Admin, 2009-03-19 15:17
Actions #1

Updated by Stano Paska over 15 years ago

Better is add htmlspecialchars:
search for all texts ###ACTION_URI### in pi1/classtx_felogin_pi1.php
add htmlspeciachars before $this->getPageLink(...

Actions #2

Updated by Oliver Hader over 15 years ago

Fine, can somebody please create a patch and attach it to this report? Thanks!

Actions #4

Updated by Oliver Hader over 15 years ago

Thanks... there's a much simpler way to do this in the called method generating the links...
The behaviour can be tested with having preserveGETvars enabled in the TypoScript configuration.

Actions #5

Updated by Stano Paska over 15 years ago

+1

Actions #6

Updated by Oliver Hader over 15 years ago

Committed to SVN:
  • TYPO_4-2 (rev. 5214)
  • Trunk (rev. 5215)
Actions #7

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF