Project

General

Profile

Actions
Copy link

Bug #20326

closed

template.php::wrapClickMenuOnIcon() uses depreciated JS Function from clickmenu.js

Added by Steffen Ritter about 15 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Francois Suter
Category:
Code Cleanup
Target version:
6.2.0
Start date:
2009-04-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

We have following in typo3/js/clickmenu.js
// deprecated functions since 4.2, here for compatibility, remove in 4.4
function showClickmenu(table, uid, listFr, enDisItems, backPath, addParams) {
Clickmenu.show(table, uid, listFr, enDisItems, backPath, addParams);
}

Mentioned function in template.php calls this one insted of the new one (line 316 trunk)

Should be a no-brainer, just replace showClickmenu by Clickmenu.show
(issue imported from #M10937)

Actions
Copy link
 #1

Updated by Francois Suter about 11 years ago

  • Category set to Code Cleanup
  • Status changed from New to Accepted
  • Assignee set to Francois Suter
  • Target version changed from 0 to 6.1.0
  • TYPO3 Version changed from 4.3 to 6.1
  • PHP Version changed from 5.2 to 5.3
  • Complexity set to easy
Actions
Copy link
 #2

Updated by Gerrit Code Review about 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20174

Actions
Copy link
 #3

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20174

Actions
Copy link
 #4

Updated by Alexander Opitz about 11 years ago

  • Target version changed from 6.1.0 to 6.2.0
Actions
Copy link
 #5

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20174

Actions
Copy link
 #6

Updated by Gerrit Code Review almost 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20174

Actions
Copy link
 #7

Updated by Francois Suter almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #8

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF