Project

General

Profile

Actions

Feature #20658

closed

Add a button to let admins create the file ENABLE_INSTALL_TOOL from the backend

Added by Michael Stucki over 15 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-06-23
Due date:
% Done:

0%

Estimated time:
PHP Version:
4.3
Tags:
Complexity:
Sprint Focus:

Description

Since #20638 the file ENABLE_INSTALL_TOOL is automatically removed if it is older than one hour. However, we expect that many admin users may need this option quickly when they probably have no shell access.

The result will be some dirty workaround which is probably even less safe than the original solution.
To prevent this, I propose to add two buttons to the users setup module of admin users that lets them easily create the file (valid for 1 hour) or remove it immediately.

Patch is written by Steffen Kamper. Thanks!
(issue imported from #M11391)


Files

bug_11391.diff (2.89 KB) bug_11391.diff Administrator Admin, 2009-06-24 00:00
follow-#11391 -4.2.diff (660 Bytes) follow-#11391 -4.2.diff Administrator Admin, 2009-07-02 22:47
11391_followup_v2.patch (957 Bytes) 11391_followup_v2.patch Administrator Admin, 2009-07-03 04:22

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #20685: ENABLE_INSTALL_TOOL is deleted after creationClosedOliver Hader2009-06-27

Actions
Actions #1

Updated by Steffen Kamper over 15 years ago

its only one button with action depend on existing of the file :)

Actions #2

Updated by Sven Juergens over 15 years ago

the patch doesn't work on 4.2.7,

there ist no definition for $this->isAdmin

Actions #3

Updated by Lars Houmark over 15 years ago

Not working for 4.2 and 4.1. Patch 11391_followup_v2.patch solves that for 4.2 at least.

Actions #4

Updated by Lars Houmark over 15 years ago

Sven: Your patch did not apply for me so I have created another one that should apply without problems.

I have also e-mailed the release managers directly, so they can attend this bug.

Actions #5

Updated by Sven Juergens over 15 years ago

thanks Lars,

in my patch there is missing the initialisation of the var $admin, too.
So thanks for that :)

Actions #6

Updated by Andy Grunwald over 15 years ago

Hey guys,
in the newest changelog (TYPO3 4.2.7, http://wiki.typo3.org/TYPO3_4.2.7#Changelog) is this patch included.
But i cant find a button in my userSettings.
So i debugged the if-condition in line 578 of typo3\sysext\setup\mod\index.php (if ($this->isAdmin) {) and the variable "$this->isAdmin" has the value "null".

My User is a Admin. I cant find a line like "$this->isAdmin = $BE_USER->isAdmin();"

if i changed the line 578 from "if ($this->isAdmin) {" to "if($BE_USER->isAdmin()){" it works very fine.
But the line 273 must be changed, too.

// Edit: Sorry, 11391_followup_v2.patch fixed this issue allready. Sorry for "not reading"

Actions #7

Updated by Michael Stucki over 15 years ago

Fixed in TYPO3 4.2.8

Actions

Also available in: Atom PDF