Project

General

Profile

Actions

Bug #20761

closed

Shortcuts broken if current directory is not in include path

Added by Mads Chr. Olesen over 15 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-07-15
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If the current directory is not in the include path, shortcuts cannot be created due to a failing require_once.
The attached simple patch (patching typo3/classes/class.shortcutmenu.php) fixes the issue.

(issue imported from #M11543)


Files

class.shortcutmenu.php (23.8 KB) class.shortcutmenu.php Administrator Admin, 2009-07-15 22:41
fix_shortcutmenu_include.patch (517 Bytes) fix_shortcutmenu_include.patch Administrator Admin, 2009-08-26 18:39
fix_shortcutmenu_include-trunk.patch (557 Bytes) fix_shortcutmenu_include-trunk.patch Administrator Admin, 2010-06-21 08:55

Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #18790: Shortcuts in Template module brokenClosedMathias Schreiber2008-05-15

Actions
Related to TYPO3 Core - Bug #22484: Shortcuts broken, if in Modules User- or Admin-ToolsClosedSusanne Moog2010-04-19

Actions
Related to TYPO3 Core - Bug #18674: Shortcut feature fails when positioned in the EMClosedChris topher2008-04-22

Actions
Actions #1

Updated by Chris topher over 14 years ago

Hi Mads,

to get your patch integrated, please send it to the Core List!
Check out http://typo3.org/teams/core/core-mailinglist-rules/

Actions #2

Updated by Steffen Gebert over 14 years ago

Can you give me a hint, how to reproduce this?

Could you please also check this with TYPO3 4.3? As we have the autoloader there, classes not included, yet, should become available magically :)

Actions #3

Updated by Mads Chr. Olesen over 14 years ago

To reproduce:
Try to create a short-cut. When opening the short-cut menu at the top, it will simply display the string "LOADING", and there will be an error in the error_log.

Reproduced on Typo3 4.3.1

I'm not sure i fully understand the development model - should I send this simple one line patch (the change and problem is quite evident by looking at it) to the mailing list?
Are patches in the bugtracker not monitored?

Actions #4

Updated by Steffen Gebert over 14 years ago

First, you should always use the most recent version (4.3.3 currently). But it's currently there, also in trunk (which will be released as 4.4.0 tomorrow).

To make sure, it gets included, you have to send it to the core list (please follow the rules: http://typo3.org/teams/core/core-mailinglist-rules/)
There's no garantuee that anybody sends your patches.

Before sending, please also change the patch according to the Coding Guide Lines and add spaces around the "." after PATH_typo3.

Actions #5

Updated by Mads Chr. Olesen over 14 years ago

Updated patch against svn trunk, sending mail to core list.

Actions #6

Updated by Steffen Kamper over 14 years ago

Committed to svn
trunk rev 7998
4_3 rev 7999

Actions

Also available in: Atom PDF