Feature #21169

add fullQuoteStr to stdWrap

Added by Martin Holtz over 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-10-01
Due date:
% Done:

0%

Estimated time:
PHP Version:
4.3
Tags:
Complexity:
Sprint Focus:

Description

(afaik) at the moment you need a userFunc to sanitze a value to be sql-injection save

  1. Example: sql-injection possible
    1 = CONTENT
    1.table = tt_content
    1.select {
    pidInList = this
    orderBy = sorting
    andWhere.cObject = TEXT
    andWhere.data = GPvar:parameter
    andWhere.wrap = title = '|'
    }
  1. how it could be:
    1 = CONTENT
    1.table = tt_content
    1.select {
    pidInList = this
    orderBy = sorting
    andWhere.cObject = TEXT
    andWhere.data = GPvar:parameter # define table name for fullQuoteStr
    andWhere.fullQuoteStr = tt_content
    andWhere.wrap = title = '|'
    }
    (issue imported from #M12094)

Files

0012094.patch (880 Bytes) 0012094.patch Administrator Admin, 2009-10-01 15:26
0012094_v2.patch (900 Bytes) 0012094_v2.patch Administrator Admin, 2009-10-01 15:39
12094_v3.patch (1006 Bytes) 12094_v3.patch Administrator Admin, 2009-10-20 21:52

Related issues

Is duplicate of TYPO3 Core - Feature #22338: Added marker in CONTENT objectClosedSteffen Kamper2010-03-29

Actions
#1

Updated by Martin Holtz over 11 years ago

there is an error in 0012094.patch - so i just uploaded 0012094_v2.patch

add &parameter=te'st

page = PAGE
page.5 = TEXT
page.5.data = GPvar:parameter
page.5.wrap = <h2>|</h2>
page.6 = TEXT
page.6.data = GPvar:parameter
page.6.wrap = <h2>|</h2>
page.6.fullQuoteStr = tt_content

#2

Updated by Martin Holtz over 11 years ago

just uploaded enhanced patch from Bastian Waidelich

patch works:)

#3

Updated by Steffen Müller over 11 years ago

v3 ships two options: quoteStr and fullQuoteStr

Usecases are demonstrated in the following two examples:

  1. 1) quoteStr
    page = PAGE
    page.10 = CONTENT
    page.10 {
    table = tt_content
    select {
    andWhere.cObject = TEXT
    andWhere.cObject {
    data = GPvar:parameter
    quoteStr = tt_content
    wrap = header LIKE "|%"
    }
    }
    }
  1. 2) fullQuoteStr
    page.20 = CONTENT
    page.20 {
    table = tt_content
    select {
    andWhere.cObject = TEXT
    andWhere.cObject {
    data = GPvar:parameter
    fullQuoteStr = tt_content
    wrap = header=|
    }
    }
    }
#4

Updated by Steffen Müller over 11 years ago

I have added an extension which provides the two functions for 4.2. It also works with 4.3 in case the patch will not make it into 4.3

#5

Updated by Steffen Müller over 11 years ago

The extension and the corresponding manual can now be found in TER:
http://typo3.org/extensions/repository/view/sm_stdwrapquote/current/

#6

Updated by Xavier Perseguers over 11 years ago

Hi,

Without testing, I guess your first example with quoteStr will fail when using DBAL and having an Oracle database. I'm pretty sure it will lead to same bug as #12721.

I guess solution would be not to use quoteStr() at all, only rely on fullQuoteStr() and "construct" the

header LIKE "|%"

either with toying with all available wrap's or with COA.

#7

Updated by Steffen Müller over 11 years ago

I don't have Oracle. Would you be so kind and test this?

The first example could be replaced by this:

page.10 = CONTENT
page.10 {
table = tt_content
select {
andWhere.cObject = TEXT
andWhere.cObject {
value = {GPvar:parameter}
insertData = 1
fullQuoteStr = tt_content
noTrimWrap = |header LIKE ||
}
}
}

Although it works fine, it looks a bit ugly.

There still might be some case where quoteStr is needed. Does anyone know a useful example?

#8

Updated by Martin Holtz over 11 years ago

well, IMHO it should not hurt to have the possibility to use quoteStr.

#9

Updated by Martin Holtz about 11 years ago

related to #22338

With #22338 it is possible to use markers which are processed via fullQuoteStr.

So this bug can be closed

#10

Updated by Steffen Gebert about 11 years ago

"With #22338 it is possible to use markers which are processed via fullQuoteStr." --> closed

Also available in: Atom PDF