Bug #21663
closed
wrong htmlspecialchars on < em > in Extension Manager
0%
Description
there is a htmlspecialchars on the html Tag < em > for categories
in class.em_index.php online 769, 830, 905
is set the htmlspecialchars
<strong>'.htmlspecialchars($this->listOrderTitle($this->MOD_SETTINGS['listOrder'],$catName)).'</strong>
in the function listOrderTitle() line 5862 you find the html tag <em>
switch($listOrder) {
case 'cat':
return isset($this->categories[$key])?$this->categories[$key]:'<em>['.$key.']</em>';
break;
...
this <em> is converted to <em>
see attached File for result
(issue imported from #M12727)
Files
Updated by Sven Juergens almost 15 years ago
upps, here is no htmlspecialchars for the text ?
ok, again... there is a htmlspecialchars an the html tag in < e m >
in the function listOrderTitle() the line sould look like this
return isset($this->categories[$key])?$this->categories[$key]:' < e m > ['.$key.'] < / e m > ';
Updated by Georg Ringer almost 15 years ago
Hi!
thanks for the bug and digging up the code! want to have a look at my patch? i will bring it to core list in the evening
Updated by Sven Juergens almost 15 years ago
hi georg,
now there is now htmlspecialchars for the other cases on listOrderTitle()
case 'author_company':
return $key;
break;
case 'state':
return $this->states[$key];
break;
case 'type':
return $this->typeDescr[$key];
break;this could be a possible XSS vulnerability,
Updated by Andreas Beutel almost 15 years ago
I suggest simply removing the emphasis-tags in listOrderTitle() since we already have the brackets as indicator, would be sufficient.
Updated by Francois Suter almost 15 years ago
Committed to trunk in revision 6573