Project

General

Profile

Actions

Bug #21853

closed

Install tool doesn´t reconize comments in localconf.php

Added by Stefano Kowalke over 14 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2009-12-13
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Install tool doesn´t reconize comments in localconf.php while updating a value.

Example:
If you have a localconf.php like this below and you switch to a new major version (4.2 -> 4.3), Update Wizard suggest you to perform an update. After this you got a message like this:
"changeCompatibilityVersion
Update successful!

The compatibility version has been set to 4.4." but if you run the Update Wizard again, you get same notice to do an upgrade.

This happens because the wizard update first occurence of the variable (reads from bottom to top), doesn´t matter if it inside a comment.
On the other hand the Wizard take care for comments if he compare installed version and new version to detect if an update needed.
So this behavior is inconstistent.

With this patch update wizard ignore lines between /* */ and behind #.

---SNIP---
$TYPO3_CONF_VARS['SYS']['compat_version'] = '4.2'; // Modified or inserted by TYPO3 Install Tool.
$TYPO3_CONF_VARS['SYS']['UTF8filesystem'] = '1';
$TYPO3_CONF_VARS['SYS']['textfile_ext'] = 'txt,html,htm,css,inc,php,php3,tmpl,js,sql,ts,t3s,t3c';
$TYPO3_CONF_VARS['BE']['sessionTimeout'] = '36000'; // Modified or inserted by TYPO3 Install Tool.
$
/*
$TYPO3_CONF_VARS['SYS']['compat_version'] = '4.2'; // Modified or inserted by TYPO3 Install Tool.
other things
*/
---SNIP---
(issue imported from #M13026)


Files

13026 .diff (1.15 KB) 13026 .diff Administrator Admin, 2009-12-13 15:23

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #18947: Compatibility version changed to 3.8 after update on version 4.2.1ClosedChristian Kuhn2008-06-13

Actions
Related to TYPO3 Core - Bug #21203: Install Tool, "Update Wizard", "changeCompatibilityVersion" without actionClosed2009-10-08

Actions
Actions

Also available in: Atom PDF