Project

General

Profile

Actions

Bug #22093

closed

jumpurl.secure crashes on spaces or umlauts in URLs

Added by Ernst Went almost 15 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2010-02-09
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Spaces or umlauts in the filename or path make a secure download link generated via the function filelink crash, i.e. the error message "Calculated juHash did not match the submitted juHash" is shown.

This is because the URL-encoding used for calculating the file hash differs in class.tslib_fe.php and class.tslib_content.php.
The verification routine for the download link in class.tslib_fe.php should use
str_replace('%2F', '/', rawurlencode($this->jumpurl))
instead of
$this->jumpurl
for calculating the hash - as it is done in the function filelink.

A patch is provided.

(issue imported from #M13484)


Files

jumpurl_encoding.patch (527 Bytes) jumpurl_encoding.patch Administrator Admin, 2010-02-09 18:33
Actions #1

Updated by Dmitry Dulepov over 14 years ago

I was unable to reproduce the issue with TYPO3 4.3. Probably, it is related to character sets. I use UTF-8 everywhere, so could not check.

I tried the following paths:
/fileadmin/doctrine-user-manual.pdf
/fileadmin/doctrine user manual.pdf
/fileadmin/??????????? ?? doctrine.pdf

Everything works perfectly.

Actions #2

Updated by Dmitry Dulepov over 14 years ago

As usual, our BT killed all non–English letters... :(

Actions #3

Updated by Ernesto Baschny about 14 years ago

Please provide some additional feedback, else we will have to close the issue. Thanks!

Actions #4

Updated by Ernesto Baschny almost 14 years ago

Closed due to lack of further feedback.

Actions #5

Updated by Susanne Moog over 13 years ago

  • Target version deleted (4.5.0)
Actions #6

Updated by Dmitry Dulepov over 11 years ago

  • Category changed from Communication to Frontend
  • Status changed from Closed to Accepted
  • TYPO3 Version changed from 4.3 to 4.5

The issue exists. Try (typo)linking with jumpurl.secure=1 to a file name with spaces. The provided patch solves the issue.

Actions #7

Updated by Dmitry Dulepov over 11 years ago

  • Status changed from Accepted to Closed

The problem is in DAM. tx_dam_tsfe replaces the file url but it does not rawurlencode() it as necessary.

Not a core bug.

Actions

Also available in: Atom PDF