Project

General

Profile

Actions
Copy link

Bug #22221

closed

includeCSS changed behavior

Added by internezzo ag over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Francois Suter
Category:
-
Target version:
-
Start date:
2010-03-02
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In Revision 5903 (http://forge.typo3.org/repositories/diff/typo3v4-core/trunk/typo3/sysext/cms/tslib/class.tslib_pagegen.php?rev=5903) the includeCSS on the page object was rewritten and it changed his behavior.

Before the change a CSS-File without a media definition had no media attribute in in the link-tag.
Now it become the media="screen" which is ignored in example in the printversion.

This behavior is related to the bug 13252 which was fixed in the revision 6960 (http://forge.typo3.org/repositories/diff/typo3v4-core?rev=6960)

There are two possible solution:
Patch 1: Replace the hardcoded "screen" with "all"
Or Patch 2: Give the "$GLOBALS['TSFE']->pSetup['includeCSS.'][$key . '.']['media']" directly to the addCssFile function. If its not set it will the defaultvalue defined by the function which is "all"

(issue imported from #M13716)

Files

Download all files
includeCSS_solution1.patch (999 Bytes) includeCSS_solution1.patch Administrator Admin, 2010-03-02 13:47
includeCSS_solution2.patch (928 Bytes) includeCSS_solution2.patch Administrator Admin, 2010-03-02 13:48
13716.diff (1.04 KB) 13716.diff Administrator Admin, 2010-03-04 14:51
Actions
Copy link

Also available in: Atom PDF