TYPO3 Core

It's a real challenge to get rid of all php notice-level errors in v4 core. This is more or less a historic problem, we are aware of this.

So until now nobody went ahead trying to fix at least some of them, error_reporting by default is set to warning level or greater.

But patches for notice level errors are certainly welcome. Please split them into small parts, fixing only one issue at a time (which makes reviews easy), keep performance effects for often used methods in mind and begin to send clean patches to the core list.

http://typo3.org/teams/core/core-mailinglist-rules/

yes I just discovered lots more. i think my work will be cut out for me. ;-)

you will find that fixing these notices will actually improve the performance of the cms generally, particularly fixing undefined indexes, as PHP will skip logically irrelevant procedures faster if you check for variable existence before you make a series of operands depending on it. it all adds up.

It is a shame they have been ignored up until now, from the quantity of notices, the performance hit is probably quite large. I will take your advice and send patches for one issue at a time. tnx for your effort.

Sorry, just a side note to the patch I supplied:

These notices that I try to get fixed are only occurring when you are trying to develop an output from an extension via eID $_GET var.

For extension development, when you are trying to get the raw output from an extension via the 'eID' method you expect little CMS involvement other than a call to bootstrap the extension, particularly when you make no other calls to CMS internals.

I know there are 10's of 100's of notices elsewhere, but these ones I feel are a little more critical to fix when you are trying to develop third-party code that should basically side step the internals of the CMS, but still be loaded as an extension.

I feel at this level it really should be 100% error free, as it is a cutting point between the CMS and pure third-party code.

If you heavily develop an extension using CMS internal methods then you should expect 'historical' error notices, but if you just access the extension 'direct' you should get zero errors from the CMS, so that when you develop with an IDE and a debugger at error_level "11", the only nags you get are with the pure third-party code you wrote.

So I hope to fix at least 7 or so notices out of a 1000+, hopefully it should be child's play to remedy.

Hi Dave,

to get your patch discussed and finally included, push it to Gerrit!

Check out:
http://wiki.typo3.org/Git_Gerrit

Thanks for your work!