Project

General

Profile

Actions

Bug #22494

closed

Missing XCLASS in class.t3lib_matchcondition_abstract.php

Added by Franz Holzinger over 14 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-04-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The file class.t3lib_matchcondition_abstract.php has no XCLASS at the end.

abstract class t3lib_matchCondition_abstract {
...

}

This is bad, because if you want to enhance the methods, then you must do the same twice for class.t3lib_matchcondition_backend.php and class.t3lib_matchcondition_frontend.php .

(issue imported from #M14171)


Files

14171.diff (760 Bytes) 14171.diff Administrator Admin, 2010-04-23 15:43
Actions #1

Updated by Steffen Gebert over 14 years ago

Can you just send a patch to the core list, please?

Actions #2

Updated by Not Only Pixel over 14 years ago

Attached patch add missing lines

Actions #3

Updated by Franz Holzinger over 14 years ago

My proposal has turned out to be wrong. The code change I need is that all common code is inserted into a new class.
class.t3lib_matchcondition_abstract.php should have a member variable which is the object of the new class. All functions must call the methods of the new class then.

Actions #4

Updated by Christian Kuhn over 14 years ago

Resolved, not fixable.

This issue is dropped for now as it doesn't make sense to xclass abstract classes.

Please feel free to come up with a better solution to handle this, and relate a new issue to this one.

Actions #5

Updated by Christian Kuhn over 14 years ago

Opened again for a possible refactoring.

Actions #6

Updated by Tolleiv Nietsch over 12 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (0)

I assume this one is not relevant anymore after #31893 ?

Actions #7

Updated by Alexander Opitz over 11 years ago

  • Status changed from Needs Feedback to Closed

No response in over one year => closed.

Actions

Also available in: Atom PDF