Bug #22494
closed
Missing XCLASS in class.t3lib_matchcondition_abstract.php
0%
Description
The file class.t3lib_matchcondition_abstract.php has no XCLASS at the end.
abstract class t3lib_matchCondition_abstract {
...
}
This is bad, because if you want to enhance the methods, then you must do the same twice for class.t3lib_matchcondition_backend.php and class.t3lib_matchcondition_frontend.php .
(issue imported from #M14171)
Files
Updated by Steffen Gebert about 14 years ago
Can you just send a patch to the core list, please?
Updated by
Updated by Franz Holzinger about 14 years ago
My proposal has turned out to be wrong. The code change I need is that all common code is inserted into a new class.
class.t3lib_matchcondition_abstract.php should have a member variable which is the object of the new class. All functions must call the methods of the new class then.
Updated by Christian Kuhn about 14 years ago
Resolved, not fixable.
This issue is dropped for now as it doesn't make sense to xclass abstract classes.
Please feel free to come up with a better solution to handle this, and relate a new issue to this one.
Updated by Christian Kuhn about 14 years ago
Opened again for a possible refactoring.
Updated by Tolleiv Nietsch about 12 years ago
- Status changed from New to Needs Feedback
- Target version deleted (
0)
I assume this one is not relevant anymore after #31893 ?
Updated by Alexander Opitz almost 11 years ago
- Status changed from Needs Feedback to Closed
No response in over one year => closed.